You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/03/03 09:19:22 UTC
[GitHub] [singa] moazreyad edited a comment on issue #599: Enabled linting
check in CI
moazreyad edited a comment on issue #599: Enabled linting check in CI
URL: https://github.com/apache/singa/pull/599#issuecomment-591966612
but why you used two machines for the static analysis? May be one is enough with two scripts for cpp and python:
```
- os: linux
stage: linting
dist: bionic
compiler: gcc
name: "Ubuntu 18.04 (Static Analysis)"
script:
- bash -ex tool/linting/cpp.sh
- bash -ex tool/linting/py.sh
```
The static analysis machine can be used also for RAT test, similar to [Apache HAWQ](https://github.com/apache/hawq/blob/master/.travis.yml#L83) and [Apache servicecomb](https://github.com/apache/servicecomb-java-chassis/blob/master/scripts/travis.sh#L34), may be something like:
```
script:
- bash -ex tool/linting/cpp.sh
- bash -ex tool/linting/py.sh
- bash -ex tool/rat.sh
```
and create [rat.sh](https://github.com/moazreyad/incubator-singa/blob/SINGA-508/tool/rat.sh).
This automatic check of licence headers with RAT will make the release process faster. Because now we have to do it manually before the release. See [this PR](https://github.com/apache/singa/pull/620).
p.s. Your commits in this pull request do not have the JIRA ticket number. The commit message should have a title which consists of the JIRA ticket No (SINGA-xxx) and title. See [here](http://singa.apache.org/develop/contribute-code.html).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services