You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/25 07:06:12 UTC

[GitHub] [spark] gatorsmile commented on a change in pull request #24414: [SPARK-22044][SQL] Add `cost` and `codegen` arguments to `explain`

gatorsmile commented on a change in pull request #24414: [SPARK-22044][SQL] Add `cost` and `codegen` arguments to `explain`
URL: https://github.com/apache/spark/pull/24414#discussion_r287553904
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
 ##########
 @@ -491,22 +525,33 @@ class Dataset[T] private[sql](
   def printSchema(level: Int): Unit = println(schema.treeString(level))
   // scalastyle:on println
 
+  /**
+   * Prints the plan or the generated code to the console for debugging
+   * purposes. The arguments `extended`, `codegen` and `cost` are mutually
+   * exclusive: at most one can be true.
+   *
+   * @param extended Print extended output with plans
+   * @param codegen Print the generated code from whole-stage codegen
+   * @param cost Print the cost information of operators
+   * @group basic
+   * @since 3.0.0
+   */
+  def explain(extended: Boolean = false,
+              codegen: Boolean = false,
+              cost: Boolean = false): Unit = {
 
 Review comment:
   The default are not optional in JAVA. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org