[GitHub] [libcloud] Kami commented on a diff in pull request #1699: Get GCE image price

[GitBox <gi...@apache.org>]

Kami commented on code in PR #1699:
URL: https://github.com/apache/libcloud/pull/1699#discussion_r889676868


##########
libcloud/pricing.py:
##########
@@ -200,6 +202,71 @@ def get_size_price(driver_type, driver_name, size_id, region=None):
     return price
 
 
+def get_gce_image_price(image_name, size_name, cores=1):

Review Comment:
   Would it be possible to make this "private" and call it inside ``get_size_price()`` method when GCE pricing is requested?
   
   Since the whole idea behind Libcloud is to try to use common / standard API as much as possible. If we create a provider specific methods everywhere it kinda defeats the purpose (yes, I know it's not always possible to do it in common / standard way, but we should try out best).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org