You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2019/04/29 09:58:51 UTC

[Impala-ASF-CR] Starting to enable 64-bit delta encoding.

Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13149


Change subject: Starting to enable 64-bit delta encoding.
......................................................................

Starting to enable 64-bit delta encoding.

Change-Id: I572e8d6e8c6b489b928a09811ead2d6c2629b17d
---
M be/src/exec/parquet/parquet-delta-decoder.h
M be/src/exec/parquet/parquet-delta-encoder.h
2 files changed, 12 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/13149/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I572e8d6e8c6b489b928a09811ead2d6c2629b17d
Gerrit-Change-Number: 13149
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>

[Impala-ASF-CR] Starting to enable 64-bit delta encoding.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13149 )

Change subject: Starting to enable 64-bit delta encoding.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13149/1/be/src/exec/parquet/parquet-delta-encoder.h
File be/src/exec/parquet/parquet-delta-encoder.h:

http://gerrit.cloudera.org:8080/#/c/13149/1/be/src/exec/parquet/parquet-delta-encoder.h@47
PS1, Line 47:   
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/13149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I572e8d6e8c6b489b928a09811ead2d6c2629b17d
Gerrit-Change-Number: 13149
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 10:08:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Starting to enable 64-bit delta encoding.

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has abandoned this change. ( http://gerrit.cloudera.org:8080/13149 )

Change subject: Starting to enable 64-bit delta encoding.
......................................................................


Abandoned

Opened by mistake.
-- 
To view, visit http://gerrit.cloudera.org:8080/13149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I572e8d6e8c6b489b928a09811ead2d6c2629b17d
Gerrit-Change-Number: 13149
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] Starting to enable 64-bit delta encoding.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13149 )

Change subject: Starting to enable 64-bit delta encoding.
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/2959/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/13149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I572e8d6e8c6b489b928a09811ead2d6c2629b17d
Gerrit-Change-Number: 13149
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 10:20:30 +0000
Gerrit-HasComments: No