[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11797: fix: add feature flag for domain sharding

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #11797:
URL: https://github.com/apache/incubator-superset/pull/11797#discussion_r529272172



##########
File path: superset-frontend/src/utils/hostNamesConfig.js
##########
@@ -16,15 +16,24 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+import {
+  initFeatureFlags,
+  isFeatureEnabled,
+  FeatureFlag,
+} from 'src/featureFlags';
+
 function getDomainsConfig() {
   const appContainer = document.getElementById('app');
   if (!appContainer) {
     return [];
   }
 
   const bootstrapData = JSON.parse(appContainer.getAttribute('data-bootstrap'));
+  // eslint-disable-next-line camelcase
+  initFeatureFlags(bootstrapData?.common?.feature_flags);

Review comment:
       this module (sometimes?) is loaded before App.jsx, it cause feature_flags is empty.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org