You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/07 06:17:45 UTC
[GitHub] [skywalking] hailin0 commented on a change in pull request #5934: Update quartz-scheduler plugin
hailin0 commented on a change in pull request #5934:
URL: https://github.com/apache/skywalking/pull/5934#discussion_r537256595
##########
File path: apm-sniffer/optional-plugins/quartz-scheduler-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/quartz/JobRunShellMethodInterceptor.java
##########
@@ -48,14 +49,15 @@
public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes, MethodInterceptResult result) throws Throwable {
JobDetail jobDetail = (JobDetail) objInst.getSkyWalkingDynamicField();
- String jobName = jobDetail.getKey().getName();
String jobGroup = jobDetail.getKey().getGroup();
- String operationName = ComponentsDefine.QUARTZ_SCHEDULER.getName() + "/" + jobName;
+ String jobName = jobDetail.getKey().getName();
+ String operationName = ComponentsDefine.QUARTZ_SCHEDULER.getName() + "/" + jobDetail.getJobClass().getName();
Review comment:
Please check again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org