[jira] Commented: (HDFS-1502) TestBlockRecovery triggers NPE in assert

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933108#action_12933108 ] 

Todd Lipcon commented on HDFS-1502:
-----------------------------------

I was looking into this yesterday. The issue is that we're calling it with a mock DataNode object in the test, but the mock isn't told what to return.

We need an Answer interface to use in this test that just returns the passed in block.

> TestBlockRecovery triggers NPE in assert
> ----------------------------------------
>
>                 Key: HDFS-1502
>                 URL: https://issues.apache.org/jira/browse/HDFS-1502
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Eli Collins
>            Priority: Minor
>             Fix For: 0.22.0
>
>
> {noformat}
> Testcase: testRBW_RWRReplicas took 10.333 sec
>         Caused an ERROR
> null
> java.lang.NullPointerException
>         at org.apache.hadoop.hdfs.server.datanode.DataNode.syncBlock(DataNode.java:1881)
>         at org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.testSyncReplicas(TestBlockRecovery.java:144)
>         at org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.testRBW_RWRReplicas(TestBlockRecovery.java:305)
> {noformat}
> {noformat}
>         Block reply = r.datanode.updateReplicaUnderRecovery(
>             r.rInfo, recoveryId, newBlock.getNumBytes());
>         assert reply.equals(newBlock) &&
>                reply.getNumBytes() == newBlock.getNumBytes() :
>           "Updated replica must be the same as the new block.";    <----- line 1881
> {noformat}
> Not sure how reply could be null since  updateReplicaUnderRecovery always returns a newly instantiated object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.