You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/09 06:53:10 UTC

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3906: Make the shadow feature more complete

terrymanu commented on a change in pull request #3906: Make the shadow feature more complete
URL: https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r364581375
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShadowPreparedStatement.java
 ##########
 @@ -66,11 +66,11 @@
     
     private final String sql;
     
-    private ShadowJudgementEngine shadowJudgementEngine;
-    
     private PreparedStatement preparedStatement;
     
     private ResultSet resultSet;
+
+    private boolean isShadowSql;
 
 Review comment:
   `isShadowSql` should name as `isShadowSQL`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services