You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/28 15:32:48 UTC

[GitHub] [incubator-doris] acelyc111 opened a new pull request #3417: [metrics] Make DorisMetrics to be a real singleton

acelyc111 opened a new pull request #3417:
URL: https://github.com/apache/incubator-doris/pull/3417


   Ref https://github.com/apache/incubator-doris/issues/3398
   NOTE: There are still some member variables are static, all of them are global metrics, like `static IntCounter fragment_requests_total;`, leave them there to avoid too many changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] chaoyli commented on pull request #3417: [metrics] Make DorisMetrics to be a real singleton

Posted by GitBox <gi...@apache.org>.
chaoyli commented on pull request #3417:
URL: https://github.com/apache/incubator-doris/pull/3417#issuecomment-620980575


   You can also change the static variable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] acelyc111 commented on pull request #3417: [metrics] Make DorisMetrics to be a real singleton

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #3417:
URL: https://github.com/apache/incubator-doris/pull/3417#issuecomment-622403624


   > You can also change the static variable.
   
   Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org