You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/08/18 12:04:39 UTC
[GitHub] [celix] Oipo opened a new pull request #276: Explicit dependency linking to support hardcoding dependencies
Oipo opened a new pull request #276:
URL: https://github.com/apache/celix/pull/276
Explicit dependency linking allows users to hardcode dependencies when required, rather than using host dependencies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo commented on pull request #276: Explicit dependency linking to support hardcoding dependencies
Posted by GitBox <gi...@apache.org>.
Oipo commented on pull request #276:
URL: https://github.com/apache/celix/pull/276#issuecomment-705419173
Uh, I don't know exactly. If a build used to link to system libraries but is now linking to provided libraries and those versions differ, the user might be confronted with different bugs in those libraries?
But it's not that big of a change, I guess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo commented on pull request #276: Explicit dependency linking to support hardcoding dependencies
Posted by GitBox <gi...@apache.org>.
Oipo commented on pull request #276:
URL: https://github.com/apache/celix/pull/276#issuecomment-705419173
Uh, I don't know exactly. If a build used to link to system libraries but is now linking to provided libraries and those versions differ, the user might be confronted with different bugs in those libraries?
But it's not that big of a change, I guess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] codecov-commenter commented on pull request #276: Explicit dependency linking to support hardcoding dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #276:
URL: https://github.com/apache/celix/pull/276#issuecomment-675439405
# [Codecov](https://codecov.io/gh/apache/celix/pull/276?src=pr&el=h1) Report
> Merging [#276](https://codecov.io/gh/apache/celix/pull/276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/efee9f2d16413de73fa094cbe29dd29d65840a35&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/celix/pull/276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 68.26% 68.25% -0.01%
==========================================
Files 136 136
Lines 27290 27290
==========================================
- Hits 18629 18627 -2
- Misses 8661 8663 +2
```
| [Impacted Files](https://codecov.io/gh/apache/celix/pull/276?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/276/diff?src=pr&el=tree#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `93.08% <0.00%> (-1.16%)` | :arrow_down: |
| [libs/framework/src/framework.c](https://codecov.io/gh/apache/celix/pull/276/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2ZyYW1ld29yay5j) | `75.44% <0.00%> (+0.14%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/276?src=pr&el=footer). Last update [efee9f2...13d4ed1](https://codecov.io/gh/apache/celix/pull/276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo merged pull request #276: Explicit dependency linking to support hardcoding dependencies
Posted by GitBox <gi...@apache.org>.
Oipo merged pull request #276:
URL: https://github.com/apache/celix/pull/276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org