You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/10 09:12:35 UTC

[GitHub] [spark] beliefer commented on pull request #37462: [SPARK-40028][SQL][FollowUp] Improve examples of string functions

beliefer commented on PR #37462:
URL: https://github.com/apache/spark/pull/37462#issuecomment-1210389706

   > > encode('Spark SQL ', 'utf-8') have better readability than x'537061726b2053514c'.
   > > Do we need to consider this factor ?
   > 
   > Well I am trying to follow the existing examples. Also, `x'537061726b2053514c'` is straightforward. For `encode('Spark SQL ', 'utf-8')`, users might need to look up the return type of `encode()` and wonder why encoding an ASCII string with utf-8.
   
   I got it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org