You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Brian McDonald (JIRA)" <ji...@apache.org> on 2010/01/22 03:40:54 UTC

[jira] Created: (WSCOMMONS-520) Add a setEntityResolver() to be used in XmlSchemaCollection.read

Add a setEntityResolver() to be used in XmlSchemaCollection.read
----------------------------------------------------------------

                 Key: WSCOMMONS-520
                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-520
             Project: WS-Commons
          Issue Type: Improvement
          Components: XmlSchema
    Affects Versions: XmlSchema 1.4.4
            Reporter: Brian McDonald


    XmlSchema read(final InputSource inputSource, ValidationEventHandler veh,
            TargetNamespaceValidator namespaceValidator) {
        try {
            DocumentBuilderFactory docFac = DocumentBuilderFactory.newInstance();
            docFac.setNamespaceAware(true);
            final DocumentBuilder builder = docFac.newDocumentBuilder();
            /* specify ER on doc builder */ 
            if (entityResolver != null) builder.setEntityResolver(entityResolver);
            Document doc = null;
            doc = parse_doPriv(inputSource, builder, doc);
            return read(doc, inputSource.getSystemId(), veh, namespaceValidator);
        } catch (ParserConfigurationException e) {
            throw new XmlSchemaException(e.getMessage());
        } catch (IOException e) {
            throw new XmlSchemaException(e.getMessage());
        } catch (SAXException e) {
            throw new XmlSchemaException(e.getMessage());
        }
    }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-520) Add a setEntityResolver() to be used in XmlSchemaCollection.read

Posted by "Brian McDonald (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906383#action_12906383 ] 

Brian McDonald commented on WSCOMMONS-520:
------------------------------------------

361d379
<             if (entityResolver != null) builder.setEntityResolver(entityResolver);
696,705d713
< 
<     private EntityResolver entityResolver;
< 
<     public EntityResolver getEntityResolver() {
<         return entityResolver;
<     }
< 
<     public void setEntityResolver(EntityResolver entityResolver) {
<         this.entityResolver = entityResolver;
<     }


> Add a setEntityResolver() to be used in XmlSchemaCollection.read
> ----------------------------------------------------------------
>
>                 Key: WSCOMMONS-520
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-520
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: XmlSchema
>    Affects Versions: XmlSchema 1.4.4
>            Reporter: Brian McDonald
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
>     XmlSchema read(final InputSource inputSource, ValidationEventHandler veh,
>             TargetNamespaceValidator namespaceValidator) {
>         try {
>             DocumentBuilderFactory docFac = DocumentBuilderFactory.newInstance();
>             docFac.setNamespaceAware(true);
>             final DocumentBuilder builder = docFac.newDocumentBuilder();
>             /* specify ER on doc builder */ 
>             if (entityResolver != null) builder.setEntityResolver(entityResolver);
>             Document doc = null;
>             doc = parse_doPriv(inputSource, builder, doc);
>             return read(doc, inputSource.getSystemId(), veh, namespaceValidator);
>         } catch (ParserConfigurationException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (IOException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (SAXException e) {
>             throw new XmlSchemaException(e.getMessage());
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-520) Add a setEntityResolver() to be used in XmlSchemaCollection.read

Posted by "Brian McDonald (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian McDonald updated WSCOMMONS-520:
-------------------------------------

    Remaining Estimate: 0.5h  (was: 0.25h)
     Original Estimate: 0.5h  (was: 0.25h)

> Add a setEntityResolver() to be used in XmlSchemaCollection.read
> ----------------------------------------------------------------
>
>                 Key: WSCOMMONS-520
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-520
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: XmlSchema
>    Affects Versions: XmlSchema 1.4.4
>            Reporter: Brian McDonald
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
>     XmlSchema read(final InputSource inputSource, ValidationEventHandler veh,
>             TargetNamespaceValidator namespaceValidator) {
>         try {
>             DocumentBuilderFactory docFac = DocumentBuilderFactory.newInstance();
>             docFac.setNamespaceAware(true);
>             final DocumentBuilder builder = docFac.newDocumentBuilder();
>             /* specify ER on doc builder */ 
>             if (entityResolver != null) builder.setEntityResolver(entityResolver);
>             Document doc = null;
>             doc = parse_doPriv(inputSource, builder, doc);
>             return read(doc, inputSource.getSystemId(), veh, namespaceValidator);
>         } catch (ParserConfigurationException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (IOException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (SAXException e) {
>             throw new XmlSchemaException(e.getMessage());
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WSCOMMONS-520) Add a setEntityResolver() to be used in XmlSchemaCollection.read

Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benson Margulies resolved WSCOMMONS-520.
----------------------------------------

    Fix Version/s: XmlSchema 1.4.7
       Resolution: Fixed

patch applied.

> Add a setEntityResolver() to be used in XmlSchemaCollection.read
> ----------------------------------------------------------------
>
>                 Key: WSCOMMONS-520
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-520
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: XmlSchema
>    Affects Versions: XmlSchema 1.4.4
>            Reporter: Brian McDonald
>             Fix For: XmlSchema 1.4.7
>
>         Attachments: WSCOMMONS-520.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
>     XmlSchema read(final InputSource inputSource, ValidationEventHandler veh,
>             TargetNamespaceValidator namespaceValidator) {
>         try {
>             DocumentBuilderFactory docFac = DocumentBuilderFactory.newInstance();
>             docFac.setNamespaceAware(true);
>             final DocumentBuilder builder = docFac.newDocumentBuilder();
>             /* specify ER on doc builder */ 
>             if (entityResolver != null) builder.setEntityResolver(entityResolver);
>             Document doc = null;
>             doc = parse_doPriv(inputSource, builder, doc);
>             return read(doc, inputSource.getSystemId(), veh, namespaceValidator);
>         } catch (ParserConfigurationException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (IOException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (SAXException e) {
>             throw new XmlSchemaException(e.getMessage());
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-520) Add a setEntityResolver() to be used in XmlSchemaCollection.read

Posted by "Brian McDonald (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian McDonald updated WSCOMMONS-520:
-------------------------------------

    Attachment: WSCOMMONS-520.patch

> Add a setEntityResolver() to be used in XmlSchemaCollection.read
> ----------------------------------------------------------------
>
>                 Key: WSCOMMONS-520
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-520
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: XmlSchema
>    Affects Versions: XmlSchema 1.4.4
>            Reporter: Brian McDonald
>         Attachments: WSCOMMONS-520.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
>     XmlSchema read(final InputSource inputSource, ValidationEventHandler veh,
>             TargetNamespaceValidator namespaceValidator) {
>         try {
>             DocumentBuilderFactory docFac = DocumentBuilderFactory.newInstance();
>             docFac.setNamespaceAware(true);
>             final DocumentBuilder builder = docFac.newDocumentBuilder();
>             /* specify ER on doc builder */ 
>             if (entityResolver != null) builder.setEntityResolver(entityResolver);
>             Document doc = null;
>             doc = parse_doPriv(inputSource, builder, doc);
>             return read(doc, inputSource.getSystemId(), veh, namespaceValidator);
>         } catch (ParserConfigurationException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (IOException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (SAXException e) {
>             throw new XmlSchemaException(e.getMessage());
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-520) Add a setEntityResolver() to be used in XmlSchemaCollection.read

Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906399#action_12906399 ] 

Benson Margulies commented on WSCOMMONS-520:
--------------------------------------------

I hate to be a pill, but the protocol is to attach a separate patch file that can be fed to the patch command. If it makes you feel any better, my idea here is that you're interested enough to eventually perhaps be a committer, and following that process is the usual first step.

> Add a setEntityResolver() to be used in XmlSchemaCollection.read
> ----------------------------------------------------------------
>
>                 Key: WSCOMMONS-520
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-520
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: XmlSchema
>    Affects Versions: XmlSchema 1.4.4
>            Reporter: Brian McDonald
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
>     XmlSchema read(final InputSource inputSource, ValidationEventHandler veh,
>             TargetNamespaceValidator namespaceValidator) {
>         try {
>             DocumentBuilderFactory docFac = DocumentBuilderFactory.newInstance();
>             docFac.setNamespaceAware(true);
>             final DocumentBuilder builder = docFac.newDocumentBuilder();
>             /* specify ER on doc builder */ 
>             if (entityResolver != null) builder.setEntityResolver(entityResolver);
>             Document doc = null;
>             doc = parse_doPriv(inputSource, builder, doc);
>             return read(doc, inputSource.getSystemId(), veh, namespaceValidator);
>         } catch (ParserConfigurationException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (IOException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (SAXException e) {
>             throw new XmlSchemaException(e.getMessage());
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-520) Add a setEntityResolver() to be used in XmlSchemaCollection.read

Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906337#action_12906337 ] 

Benson Margulies commented on WSCOMMONS-520:
--------------------------------------------

Brian,

Could you post an actual patch for this? With a test case?

Thanks.


> Add a setEntityResolver() to be used in XmlSchemaCollection.read
> ----------------------------------------------------------------
>
>                 Key: WSCOMMONS-520
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-520
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: XmlSchema
>    Affects Versions: XmlSchema 1.4.4
>            Reporter: Brian McDonald
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
>     XmlSchema read(final InputSource inputSource, ValidationEventHandler veh,
>             TargetNamespaceValidator namespaceValidator) {
>         try {
>             DocumentBuilderFactory docFac = DocumentBuilderFactory.newInstance();
>             docFac.setNamespaceAware(true);
>             final DocumentBuilder builder = docFac.newDocumentBuilder();
>             /* specify ER on doc builder */ 
>             if (entityResolver != null) builder.setEntityResolver(entityResolver);
>             Document doc = null;
>             doc = parse_doPriv(inputSource, builder, doc);
>             return read(doc, inputSource.getSystemId(), veh, namespaceValidator);
>         } catch (ParserConfigurationException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (IOException e) {
>             throw new XmlSchemaException(e.getMessage());
>         } catch (SAXException e) {
>             throw new XmlSchemaException(e.getMessage());
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.