You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "schneems (via GitHub)" <gi...@apache.org> on 2025/01/17 01:59:53 UTC
[PR] Remove extra text from license [zookeeper]
schneems opened a new pull request, #2219:
URL: https://github.com/apache/zookeeper/pull/2219
The Apache 2.0 license on the website shows that it ends after "END OF TERMS AND CONDITIONS" https://www.apache.org/licenses/LICENSE-2.0
<img width="1401" alt="387383537-f56c8594-5c32-41d5-a5b7-f4a587125ca2" src="https://github.com/user-attachments/assets/ca29c9a4-b520-401f-9e6c-ce2b3464e942">
This text exists because it's been mistakenly copied and pasted from https://www.apache.org/licenses/LICENSE-2.0.txt where it includes placeholder text and the intent seems to be reproducing the application instructions as seen on https://www.apache.org/licenses/LICENSE-2.0 rather than as text that's intended to be included in the license.
The text removed in this PR diverges slightly from the text on https://www.apache.org/licenses/LICENSE-2.0#apply
> How to apply the Apache License to your work
>
> Include a copy of the Apache License, typically in a file called LICENSE, in your work, and consider also including a NOTICE file that references the License.
>
> To apply the Apache License to specific files in your work, attach the following boilerplate declaration, replacing the fields enclosed by brackets "[]" with your own identifying information. (Don't include the brackets!) Enclose the text in the appropriate comment syntax for the file format. We also recommend that you include a file or class name and description of purpose on the same "printed page" as the copyright notice for easier identification within third-party archives.
The text on the website ⬆️ seems to indicate that placing the Apache 2.0 license text in a `LICENSE` is sufficient for a project. The text given in the text file ⬇️ does not mention a LICENSE file and instead seems to imply that the full text of the Apache 2.0 license is not required, but use the "boilerplate" after swapping out the placeholders.
Looking at other high profile projects that use the Apache 2.0 license it looks like their understanding matches mine, here's Rust https://github.com/rust-lang/rust/blob/fda68927475070696fcc9d1f5c9c990f0e1af87a/LICENSE-APACHE. Here's a discussion from 5 years ago on whether to remove the appendix from there https://github.com/rust-lang/rust/pull/67734.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove extra text from license [zookeeper]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #2219:
URL: https://github.com/apache/zookeeper/pull/2219#issuecomment-2689790320
Agree with @ctubbsii's comment. Closed as not an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove extra text from license [zookeeper]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed pull request #2219: Remove extra text from license
URL: https://github.com/apache/zookeeper/pull/2219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove extra text from license [zookeeper]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #2219:
URL: https://github.com/apache/zookeeper/pull/2219#issuecomment-2640358403
This is not an issue to solve. It is standard practice, and perfectly acceptable, to copy the entirety of the LICENSE text, with appendix included, for one's own LICENSE file in their project. This is especially true of ASF projects, themselves, which include a copy of the full text of the license. It is not strictly necessary to copy the full license to denote that the project is licensed under its terms, but ASF projects do that, and the appendix is typically included, because the text tends to be copied from https://www.apache.org/licenses/LICENSE-2.0.txt (or generated from GitHub's project templates, which also includes the appendix). Other projects may merely have an SPDX header or the suggested header from the license's appendix (or similar), or like Rust, only include the license terms without the appendix, but at ASF, we typically just include the full text of the license from https://www.apache.org/licenses/LICENSE-2.0.txt . I think this is a good thing to do, because at
the ASF, we have an interest in sharing the license for others to use as well, and the appendix is a useful thing to include to show others how they can make use of the license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org