You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "mridulpathak (via GitHub)" <gi...@apache.org> on 2026/09/27 08:02:40 UTC

[PR] Fixed: Three regressions in the minilang-to-Groovy conversion of CostServices.groovy (OFBIZ-13617) [ofbiz-framework]

mridulpathak opened a new pull request, #2121:
URL: https://github.com/apache/ofbiz-framework/pull/2121

   - calculateProductCosts() referenced the undeclared totalCostByType instead of totalCostsByType, silently dropping prior task-cost accumulation for repeated cost types.
   - calculateProductAverageCost() rounded totals once at the end instead of after every iteration (HALF_EVEN, 2 decimals) as mini-lang's <calculate> defaults to, which can shift the final average by a cent.
   - updateProductAverageCostOnReceiveInventory() read the nonexistent property finaccout.decimals instead of finaccount.decimals, silently falling back to a hardcoded default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fixed: Three regressions in the minilang-to-Groovy conversion of CostServices.groovy (OFBIZ-13617) [ofbiz-framework]

Posted by "mridulpathak (via GitHub)" <gi...@apache.org>.
mridulpathak merged PR #2121:
URL: https://github.com/apache/ofbiz-framework/pull/2121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org