You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Gordon Sim (JIRA)" <qp...@incubator.apache.org> on 2010/03/30 19:08:27 UTC
[jira] Commented: (QPID-2475) qpid/messaging/Session.h r928855
breaks Windows build - macro conflict
[ https://issues.apache.org/jira/browse/QPID-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851467#action_12851467 ]
Gordon Sim commented on QPID-2475:
----------------------------------
Sorry! We can certainly change it. I'm not mad on BOUNDLESS - how about FOREVER? Or could we use camel case rather than pure caps for these constants?
> qpid/messaging/Session.h r928855 breaks Windows build - macro conflict
> ----------------------------------------------------------------------
>
> Key: QPID-2475
> URL: https://issues.apache.org/jira/browse/QPID-2475
> Project: Qpid
> Issue Type: Bug
> Components: C++ Client
> Affects Versions: 0.7
> Environment: Windows
> Reporter: Steve Huston
>
> this change broke on Windows:
> Index: C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h
> ===================================================================
> --- C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h (revision 928854)
> +++ C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h (revision 928855)
> @@ -102,7 +102,7 @@
> * which case the passed in receiver reference will be set to the
> * receiver for that message or false if no message was available.
> */
> - QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration timeout=INFINITE_DURATION);
> + QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration timeout=Duration::INFINITE);
> /**
> * Returns the receiver for the next available message. If there
> * are no available messages at present the call will block for up
> @@ -111,7 +111,7 @@
> *@exception Receiver::NoMessageAvailable if no message became available in
> * time.
> */
> - QPID_CLIENT_EXTERN Receiver nextReceiver(Duration timeout=INFINITE_DURATION);
> + QPID_CLIENT_EXTERN Receiver nextReceiver(Duration timeout=Duration::INFINITE);
>
> /**
> * Create a new sender through which messages can be sent to the
> These errors occur during compile:
> C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(105) : error C2589: 'constant' : illegal token on right side of '::'
> C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(114) : error C2589: 'constant' : illegal token on right side of '::'
> Because of this definition in the Windows SDK:
> #define INFINITE 0xFFFFFFFF // Infinite timeout
> Can Duration::INFINITE, although a very good name, change to something like BOUNDLESS?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org