You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pivot.apache.org by cb...@apache.org on 2010/09/16 17:22:17 UTC
svn commit: r997787 - in /pivot/trunk:
wtk-terra/src/org/apache/pivot/wtk/skin/terra/
wtk/src/org/apache/pivot/wtk/skin/
Author: cbartlett
Date: Thu Sep 16 15:22:16 2010
New Revision: 997787
URL: http://svn.apache.org/viewvc?rev=997787&view=rev
Log:
PIVOT-637 - Javadoc comments for ComponentKeyListener#keyTyped() methods
Modified:
pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
Modified: pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
URL: http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java?rev=997787&r1=997786&r2=997787&view=diff
==============================================================================
--- pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java (original)
+++ pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java Thu Sep 16 15:22:16 2010
@@ -1073,6 +1073,10 @@ public class TerraListViewSkin extends C
return consumed;
}
+ /**
+ * Select the next enabled list item where the first character of the
+ * rendered text matches the typed key (case insensitive).
+ */
@Override
public boolean keyTyped(Component component, char character) {
boolean consumed = super.keyTyped(component, character);
Modified: pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
URL: http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java?rev=997787&r1=997786&r2=997787&view=diff
==============================================================================
--- pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java (original)
+++ pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java Thu Sep 16 15:22:16 2010
@@ -529,6 +529,10 @@ public class TerraMenuSkin extends Conta
return consumed;
}
+ /**
+ * Select the next enabled menu item where the first character of the
+ * rendered text matches the typed key (case insensitive).
+ */
@Override
public boolean keyTyped(Component component, char character) {
boolean consumed = super.keyTyped(component, character);
Modified: pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
URL: http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java?rev=997787&r1=997786&r2=997787&view=diff
==============================================================================
--- pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java (original)
+++ pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java Thu Sep 16 15:22:16 2010
@@ -292,6 +292,10 @@ public class TerraSpinnerSkin extends Co
return consumed;
}
+ /**
+ * Select the next spinner item where the first character of the
+ * rendered text matches the typed key (case insensitive).
+ */
@Override
public boolean keyTyped(Component component, char character) {
boolean consumed = super.keyTyped(component, character);
Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
URL: http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java?rev=997787&r1=997786&r2=997787&view=diff
==============================================================================
--- pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java (original)
+++ pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java Thu Sep 16 15:22:16 2010
@@ -32,10 +32,10 @@ import org.apache.pivot.wtk.ComponentSta
import org.apache.pivot.wtk.Container;
import org.apache.pivot.wtk.Cursor;
import org.apache.pivot.wtk.Dimensions;
-import org.apache.pivot.wtk.FocusTraversalDirection;
import org.apache.pivot.wtk.Display;
import org.apache.pivot.wtk.DragSource;
import org.apache.pivot.wtk.DropTarget;
+import org.apache.pivot.wtk.FocusTraversalDirection;
import org.apache.pivot.wtk.Keyboard;
import org.apache.pivot.wtk.Label;
import org.apache.pivot.wtk.MenuHandler;
@@ -307,6 +307,12 @@ public abstract class ComponentSkin impl
return false;
}
+ /**
+ * {@link Keyboard.KeyCode#TAB} transfers focus
+ * {@link FocusTraversalDirection#FORWARD}<br> {@link Keyboard.KeyCode#TAB}+
+ * {@link Keyboard.Modifier#SHIFT} transfers focus
+ * {@link FocusTraversalDirection#BACKWARD}
+ */
@Override
public boolean keyPressed(Component component, int keyCode, Keyboard.KeyLocation keyLocation) {
boolean consumed = false;
Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
URL: http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java?rev=997787&r1=997786&r2=997787&view=diff
==============================================================================
--- pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java (original)
+++ pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java Thu Sep 16 15:22:16 2010
@@ -23,8 +23,8 @@ import org.apache.pivot.wtk.ComponentKey
import org.apache.pivot.wtk.ComponentMouseButtonListener;
import org.apache.pivot.wtk.Container;
import org.apache.pivot.wtk.ContainerMouseListener;
-import org.apache.pivot.wtk.FocusTraversalDirection;
import org.apache.pivot.wtk.Display;
+import org.apache.pivot.wtk.FocusTraversalDirection;
import org.apache.pivot.wtk.Keyboard;
import org.apache.pivot.wtk.ListButton;
import org.apache.pivot.wtk.ListButtonListener;
@@ -302,6 +302,10 @@ public abstract class ListButtonSkin ext
return consumed;
}
+ /**
+ * Select the next enabled list item where the first character of the
+ * rendered text matches the typed key (case insensitive).
+ */
@Override
public boolean keyTyped(Component component, char character) {
boolean consumed = super.keyTyped(component, character);
Re: svn commit: r997787 - in /pivot/trunk: wtk-terra/src/org/apache/pivot/wtk/skin/terra/
wtk/src/org/apache/pivot/wtk/skin/
Posted by Chris Bartlett <cb...@gmail.com>.
No problem. There are plenty of classes to get through, so this seemed
like a fairly logical way to proceed.
It also has the benefit of making it a little easier to note key handling
similarities and differences between components.
On 16 September 2010 22:53, Greg Brown <gk...@mac.com> wrote:
> > What inconsistency do you mean?
> > Are you referring to the fact I have only checked in javadocs for
> > ComponentKeyListener#keyTyped() methods? (I am working through
> > ComponentKeyListener a method at a time)
>
> OK - I thought that this was a one-off, only meant to document the behavior
> of this method. Thanks for clarifying.
>
>
Re: svn commit: r997787 - in /pivot/trunk:
wtk-terra/src/org/apache/pivot/wtk/skin/terra/
wtk/src/org/apache/pivot/wtk/skin/
Posted by Greg Brown <gk...@mac.com>.
> What inconsistency do you mean?
> Are you referring to the fact I have only checked in javadocs for
> ComponentKeyListener#keyTyped() methods? (I am working through
> ComponentKeyListener a method at a time)
OK - I thought that this was a one-off, only meant to document the behavior of this method. Thanks for clarifying.
Re: svn commit: r997787 - in /pivot/trunk: wtk-terra/src/org/apache/pivot/wtk/skin/terra/
wtk/src/org/apache/pivot/wtk/skin/
Posted by Chris Bartlett <cb...@gmail.com>.
Initially I just want to get *something* documented. This can then be
collated and written up in the class doc as you suggested.
Ultimately I am planning to add a table to the class docs which will list
the keystroke, modifiers, description & when/if it consumes.
What inconsistency do you mean?
Are you referring to the fact I have only checked in javadocs for
ComponentKeyListener#keyTyped() methods? (I am working through
ComponentKeyListener a method at a time)
Or that other, non-ComponentKeyListener events are not documented?
Chris
On 16 September 2010 22:26, Greg Brown <gk...@mac.com> wrote:
> This seems fine, but it does create an inconsistency with the other event
> handlers which don't have such Javadoc. Maybe a better place to capture this
> would be in the class doc? There, we could describe how the skin behaves as
> a whole.
>
> On Sep 16, 2010, at 11:22 AM, cbartlett@apache.org wrote:
>
> > Author: cbartlett
> > Date: Thu Sep 16 15:22:16 2010
> > New Revision: 997787
> >
> > URL: http://svn.apache.org/viewvc?rev=997787&view=rev
> > Log:
> > PIVOT-637 - Javadoc comments for ComponentKeyListener#keyTyped() methods
> >
> > Modified:
> >
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
> >
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
> >
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
> > pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
> > pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
> > ...
>
>
>
Re: svn commit: r997787 - in /pivot/trunk:
wtk-terra/src/org/apache/pivot/wtk/skin/terra/
wtk/src/org/apache/pivot/wtk/skin/
Posted by Greg Brown <gk...@mac.com>.
This seems fine, but it does create an inconsistency with the other event handlers which don't have such Javadoc. Maybe a better place to capture this would be in the class doc? There, we could describe how the skin behaves as a whole.
On Sep 16, 2010, at 11:22 AM, cbartlett@apache.org wrote:
> Author: cbartlett
> Date: Thu Sep 16 15:22:16 2010
> New Revision: 997787
>
> URL: http://svn.apache.org/viewvc?rev=997787&view=rev
> Log:
> PIVOT-637 - Javadoc comments for ComponentKeyListener#keyTyped() methods
>
> Modified:
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
> ...
Re: svn commit: r997787 - in /pivot/trunk: wtk-terra/src/org/apache/pivot/wtk/skin/terra/
wtk/src/org/apache/pivot/wtk/skin/
Posted by Chris Bartlett <cb...@apache.org>.
FYI - I just noticed that some warnings are showing up when generating
javadocs outside of Eclipse (due to these new comments)
I have a fix for it and will apply it shortly.
On 16 September 2010 22:22, <cb...@apache.org> wrote:
> Author: cbartlett
> Date: Thu Sep 16 15:22:16 2010
> New Revision: 997787
>
> URL: http://svn.apache.org/viewvc?rev=997787&view=rev
> Log:
> PIVOT-637 - Javadoc comments for ComponentKeyListener#keyTyped() methods
>
> Modified:
>
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
>
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
>
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
>
> Modified:
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
> URL:
> http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java?rev=997787&r1=997786&r2=997787&view=diff
>
> ==============================================================================
> ---
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
> (original)
> +++
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
> Thu Sep 16 15:22:16 2010
> @@ -1073,6 +1073,10 @@ public class TerraListViewSkin extends C
> return consumed;
> }
>
> + /**
> + * Select the next enabled list item where the first character of the
> + * rendered text matches the typed key (case insensitive).
> + */
> @Override
> public boolean keyTyped(Component component, char character) {
> boolean consumed = super.keyTyped(component, character);
>
> Modified:
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
> URL:
> http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java?rev=997787&r1=997786&r2=997787&view=diff
>
> ==============================================================================
> ---
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
> (original)
> +++
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
> Thu Sep 16 15:22:16 2010
> @@ -529,6 +529,10 @@ public class TerraMenuSkin extends Conta
> return consumed;
> }
>
> + /**
> + * Select the next enabled menu item where the first character of the
> + * rendered text matches the typed key (case insensitive).
> + */
> @Override
> public boolean keyTyped(Component component, char character) {
> boolean consumed = super.keyTyped(component, character);
>
> Modified:
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
> URL:
> http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java?rev=997787&r1=997786&r2=997787&view=diff
>
> ==============================================================================
> ---
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
> (original)
> +++
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
> Thu Sep 16 15:22:16 2010
> @@ -292,6 +292,10 @@ public class TerraSpinnerSkin extends Co
> return consumed;
> }
>
> + /**
> + * Select the next spinner item where the first character of the
> + * rendered text matches the typed key (case insensitive).
> + */
> @Override
> public boolean keyTyped(Component component, char character) {
> boolean consumed = super.keyTyped(component, character);
>
> Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
> URL:
> http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java?rev=997787&r1=997786&r2=997787&view=diff
>
> ==============================================================================
> --- pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
> (original)
> +++ pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java Thu
> Sep 16 15:22:16 2010
> @@ -32,10 +32,10 @@ import org.apache.pivot.wtk.ComponentSta
> import org.apache.pivot.wtk.Container;
> import org.apache.pivot.wtk.Cursor;
> import org.apache.pivot.wtk.Dimensions;
> -import org.apache.pivot.wtk.FocusTraversalDirection;
> import org.apache.pivot.wtk.Display;
> import org.apache.pivot.wtk.DragSource;
> import org.apache.pivot.wtk.DropTarget;
> +import org.apache.pivot.wtk.FocusTraversalDirection;
> import org.apache.pivot.wtk.Keyboard;
> import org.apache.pivot.wtk.Label;
> import org.apache.pivot.wtk.MenuHandler;
> @@ -307,6 +307,12 @@ public abstract class ComponentSkin impl
> return false;
> }
>
> + /**
> + * {@link Keyboard.KeyCode#TAB} transfers focus
> + * {@link FocusTraversalDirection#FORWARD}<br> {@link
> Keyboard.KeyCode#TAB}+
> + * {@link Keyboard.Modifier#SHIFT} transfers focus
> + * {@link FocusTraversalDirection#BACKWARD}
> + */
> @Override
> public boolean keyPressed(Component component, int keyCode,
> Keyboard.KeyLocation keyLocation) {
> boolean consumed = false;
>
> Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
> URL:
> http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java?rev=997787&r1=997786&r2=997787&view=diff
>
> ==============================================================================
> --- pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
> (original)
> +++ pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java Thu
> Sep 16 15:22:16 2010
> @@ -23,8 +23,8 @@ import org.apache.pivot.wtk.ComponentKey
> import org.apache.pivot.wtk.ComponentMouseButtonListener;
> import org.apache.pivot.wtk.Container;
> import org.apache.pivot.wtk.ContainerMouseListener;
> -import org.apache.pivot.wtk.FocusTraversalDirection;
> import org.apache.pivot.wtk.Display;
> +import org.apache.pivot.wtk.FocusTraversalDirection;
> import org.apache.pivot.wtk.Keyboard;
> import org.apache.pivot.wtk.ListButton;
> import org.apache.pivot.wtk.ListButtonListener;
> @@ -302,6 +302,10 @@ public abstract class ListButtonSkin ext
> return consumed;
> }
>
> + /**
> + * Select the next enabled list item where the first character of the
> + * rendered text matches the typed key (case insensitive).
> + */
> @Override
> public boolean keyTyped(Component component, char character) {
> boolean consumed = super.keyTyped(component, character);
>
>
>
Re: svn commit: r997787 - in /pivot/trunk: wtk-terra/src/org/apache/pivot/wtk/skin/terra/
wtk/src/org/apache/pivot/wtk/skin/
Posted by Chris Bartlett <cb...@apache.org>.
FYI - I just noticed that some warnings are showing up when generating
javadocs outside of Eclipse (due to these new comments)
I have a fix for it and will apply it shortly.
On 16 September 2010 22:22, <cb...@apache.org> wrote:
> Author: cbartlett
> Date: Thu Sep 16 15:22:16 2010
> New Revision: 997787
>
> URL: http://svn.apache.org/viewvc?rev=997787&view=rev
> Log:
> PIVOT-637 - Javadoc comments for ComponentKeyListener#keyTyped() methods
>
> Modified:
>
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
>
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
>
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
>
> Modified:
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
> URL:
> http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java?rev=997787&r1=997786&r2=997787&view=diff
>
> ==============================================================================
> ---
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
> (original)
> +++
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java
> Thu Sep 16 15:22:16 2010
> @@ -1073,6 +1073,10 @@ public class TerraListViewSkin extends C
> return consumed;
> }
>
> + /**
> + * Select the next enabled list item where the first character of the
> + * rendered text matches the typed key (case insensitive).
> + */
> @Override
> public boolean keyTyped(Component component, char character) {
> boolean consumed = super.keyTyped(component, character);
>
> Modified:
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
> URL:
> http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java?rev=997787&r1=997786&r2=997787&view=diff
>
> ==============================================================================
> ---
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
> (original)
> +++
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java
> Thu Sep 16 15:22:16 2010
> @@ -529,6 +529,10 @@ public class TerraMenuSkin extends Conta
> return consumed;
> }
>
> + /**
> + * Select the next enabled menu item where the first character of the
> + * rendered text matches the typed key (case insensitive).
> + */
> @Override
> public boolean keyTyped(Component component, char character) {
> boolean consumed = super.keyTyped(component, character);
>
> Modified:
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
> URL:
> http://svn.apache.org/viewvc/pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java?rev=997787&r1=997786&r2=997787&view=diff
>
> ==============================================================================
> ---
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
> (original)
> +++
> pivot/trunk/wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java
> Thu Sep 16 15:22:16 2010
> @@ -292,6 +292,10 @@ public class TerraSpinnerSkin extends Co
> return consumed;
> }
>
> + /**
> + * Select the next spinner item where the first character of the
> + * rendered text matches the typed key (case insensitive).
> + */
> @Override
> public boolean keyTyped(Component component, char character) {
> boolean consumed = super.keyTyped(component, character);
>
> Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
> URL:
> http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java?rev=997787&r1=997786&r2=997787&view=diff
>
> ==============================================================================
> --- pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
> (original)
> +++ pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java Thu
> Sep 16 15:22:16 2010
> @@ -32,10 +32,10 @@ import org.apache.pivot.wtk.ComponentSta
> import org.apache.pivot.wtk.Container;
> import org.apache.pivot.wtk.Cursor;
> import org.apache.pivot.wtk.Dimensions;
> -import org.apache.pivot.wtk.FocusTraversalDirection;
> import org.apache.pivot.wtk.Display;
> import org.apache.pivot.wtk.DragSource;
> import org.apache.pivot.wtk.DropTarget;
> +import org.apache.pivot.wtk.FocusTraversalDirection;
> import org.apache.pivot.wtk.Keyboard;
> import org.apache.pivot.wtk.Label;
> import org.apache.pivot.wtk.MenuHandler;
> @@ -307,6 +307,12 @@ public abstract class ComponentSkin impl
> return false;
> }
>
> + /**
> + * {@link Keyboard.KeyCode#TAB} transfers focus
> + * {@link FocusTraversalDirection#FORWARD}<br> {@link
> Keyboard.KeyCode#TAB}+
> + * {@link Keyboard.Modifier#SHIFT} transfers focus
> + * {@link FocusTraversalDirection#BACKWARD}
> + */
> @Override
> public boolean keyPressed(Component component, int keyCode,
> Keyboard.KeyLocation keyLocation) {
> boolean consumed = false;
>
> Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
> URL:
> http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java?rev=997787&r1=997786&r2=997787&view=diff
>
> ==============================================================================
> --- pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
> (original)
> +++ pivot/trunk/wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java Thu
> Sep 16 15:22:16 2010
> @@ -23,8 +23,8 @@ import org.apache.pivot.wtk.ComponentKey
> import org.apache.pivot.wtk.ComponentMouseButtonListener;
> import org.apache.pivot.wtk.Container;
> import org.apache.pivot.wtk.ContainerMouseListener;
> -import org.apache.pivot.wtk.FocusTraversalDirection;
> import org.apache.pivot.wtk.Display;
> +import org.apache.pivot.wtk.FocusTraversalDirection;
> import org.apache.pivot.wtk.Keyboard;
> import org.apache.pivot.wtk.ListButton;
> import org.apache.pivot.wtk.ListButtonListener;
> @@ -302,6 +302,10 @@ public abstract class ListButtonSkin ext
> return consumed;
> }
>
> + /**
> + * Select the next enabled list item where the first character of the
> + * rendered text matches the typed key (case insensitive).
> + */
> @Override
> public boolean keyTyped(Component component, char character) {
> boolean consumed = super.keyTyped(component, character);
>
>
>