You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by bo...@apache.org on 2017/12/22 12:56:23 UTC
incubator-airflow git commit: [AIRFLOW-1920] Update CONTRIBUTING.md
to reflect enforced linting rules
Repository: incubator-airflow
Updated Branches:
refs/heads/master d0db00959 -> 4b4132dfd
[AIRFLOW-1920] Update CONTRIBUTING.md to reflect enforced linting rules
Updates Contributing guidelines to reflect
enforced linting rules & adds
instructions for running single file unit tests.
Closes #2878 from andyxhadji/AIRFLOW-1920
Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/4b4132df
Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/4b4132df
Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/4b4132df
Branch: refs/heads/master
Commit: 4b4132dfdb1e80426232cc08ebae1828c6318742
Parents: d0db009
Author: Andy Hadjigeorgiou <ah...@columbia.edu>
Authored: Fri Dec 22 13:56:18 2017 +0100
Committer: Bolke de Bruin <bo...@xs4all.nl>
Committed: Fri Dec 22 13:56:18 2017 +0100
----------------------------------------------------------------------
CONTRIBUTING.md | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/4b4132df/CONTRIBUTING.md
----------------------------------------------------------------------
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 04b0d7f..da82805 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -123,7 +123,7 @@ which you can setup on your fork as well to check before you submit your
PR. We currently enforce most [PEP8](https://www.python.org/dev/peps/pep-0008/)
and a few other linting rules. It is usually a good idea to lint locally
as well using [flake8](https://flake8.readthedocs.org/en/latest/)
-using `flake8 airflow tests`
+using `flake8 airflow tests`. `git diff upstream/master -u -- "*.py" | flake8 --diff` will return any changed files in your branch that require linting.
9. Please read this excellent [article](http://chris.beams.io/posts/git-commit/) on
commit messages and adhere to them. It makes the lives of those who
come after you a lot easier.
@@ -135,6 +135,10 @@ Tests can then be run with (see also the [Running unit tests](#running-unit-test
./run_unit_tests.sh
+Individual test files can be run with:
+
+ nosetests [path to file]
+
#### Running unit tests
We *highly* recommend setting up [Travis CI](https://travis-ci.org/) on