You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/07/11 10:48:15 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41937: [SPARK-43974][CONNECT][BUILD] Upgrade buf to v1.23.1
panbingkun opened a new pull request, #41937:
URL: https://github.com/apache/spark/pull/41937
### What changes were proposed in this pull request?
The pr aims to upgrade buf from 1.20.0 to 1.23.1
### Why are the changes needed?
1.Release Notes:
- https://github.com/bufbuild/buf/releases/tag/v1.23.1
- https://github.com/bufbuild/buf/releases/tag/v1.23.0
- https://github.com/bufbuild/buf/releases/tag/v1.22.0
- https://github.com/bufbuild/buf/releases/tag/v1.21.0
2.The new version brings some bug fixed and improvment, as follow:
- Fix issue where buf beta graph would not print modules within a workspace that
had no dependencies or dependents.
- Fix issue where buf beta graph would print warnings for missing dependencies
that were actually present.
- Fix issue where locally-produced images did not have module information if the corresponding
module was stored in the new cache.
- Remove buf beta registry template.
- Remove buf beta registry plugin {create,deprecate,list,undeprecate,version} and replace with
buf beta registry plugin {push,delete}.
- Update buf beta price with the latest pricing information.
3.Manually test: dev/connect-gen-protos.sh, this upgrade will not change the generated files.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Manually test
- Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41937: [SPARK-43974][CONNECT][BUILD] Upgrade buf to v1.23.1
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41937:
URL: https://github.com/apache/spark/pull/41937#issuecomment-1630601560
In order to address the https://github.com/apache/spark/pull/41933 issue, the above PR has been reversed and is now resubmitted.
@zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #41937: [SPARK-43974][CONNECT][BUILD] Upgrade buf to v1.23.1
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #41937:
URL: https://github.com/apache/spark/pull/41937#issuecomment-1632257665
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41937: [SPARK-43974][CONNECT][BUILD] Upgrade buf to v1.23.1
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41937:
URL: https://github.com/apache/spark/pull/41937#issuecomment-1631868678
Recheck this upgrade will not change the generated files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #41937: [SPARK-43974][CONNECT][BUILD] Upgrade buf to v1.23.1
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #41937: [SPARK-43974][CONNECT][BUILD] Upgrade buf to v1.23.1
URL: https://github.com/apache/spark/pull/41937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org