You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by swgkg <gi...@git.apache.org> on 2014/11/27 07:20:24 UTC
[GitHub] stratos pull request: Introduce the enum for messaging topics
GitHub user swgkg opened a pull request:
https://github.com/apache/stratos/pull/121
Introduce the enum for messaging topics
Fixes for STRATOS-1009 fixes
1.Introduce the enum for messaging topics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gayangunarathne/stratos master-reviewfixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 6bbe86d6033bc10300a73c6ea2aed2c154c88a0b
Author: gayan <ga...@puppet.gayan.org>
Date: 2014-11-27T06:09:05Z
STRATOS-1009 fixes- Introduce the enum for messaging topics
commit a82f37cc6b7ba773e4f10b2d6439af74eb6528c0
Author: gayan <ga...@puppet.gayan.org>
Date: 2014-11-27T06:16:30Z
STRATOS-1009 fixes- Introduce the enum for messaging topics
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Introduce the enum for messaging topics
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on the pull request:
https://github.com/apache/stratos/pull/121#issuecomment-64868698
Hi Gayan,
Thanks for fixing the above issue. I just tried to merge this but seems like there are conflicts. Can you please update the pull request branch with master?
Thanks
Imesh
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Introduce the enum for messaging topics
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on a diff in the pull request:
https://github.com/apache/stratos/pull/121#discussion_r21017047
--- Diff: components/org.apache.stratos.messaging/src/main/java/org/apache/stratos/messaging/broker/heartbeat/TopicHealthChecker.java ---
@@ -58,8 +57,8 @@ public void run() {
Thread.sleep(Util.getAveragePingInterval());
// A ping event is published to detect a session timeout
- EventPublisherPool.getPublisher(Constants.PING_TOPIC).publish(new PingEvent(),
- false);
+ EventPublisherPool.getPublisher(Util.Topics.PING_TOPIC.getTopicName()).publish(new PingEvent(),
--- End diff --
Gayan: We removed the ping topic recently. May be this is not needed.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Introduce the enum for messaging topics
Posted by swgkg <gi...@git.apache.org>.
Github user swgkg commented on the pull request:
https://github.com/apache/stratos/pull/121#issuecomment-64885269
Hi Imesh,
I merge those changes with new changes and make a new PR #125
Thanks,
Gayan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Introduce the enum for messaging topics
Posted by swgkg <gi...@git.apache.org>.
Github user swgkg closed the pull request at:
https://github.com/apache/stratos/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Introduce the enum for messaging topics
Posted by swgkg <gi...@git.apache.org>.
Github user swgkg commented on the pull request:
https://github.com/apache/stratos/pull/121#issuecomment-65020126
Changes merge with #127 , hence closing the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Introduce the enum for messaging topics
Posted by swgkg <gi...@git.apache.org>.
Github user swgkg commented on the pull request:
https://github.com/apache/stratos/pull/121#issuecomment-64860519
Hi Imesh,
Remove PING topic and update the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---