You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by sansanichfb <gi...@git.apache.org> on 2017/03/22 18:37:32 UTC

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

GitHub user sansanichfb opened a pull request:

    https://github.com/apache/incubator-hawq/pull/1185

    HAWQ-1402. Updated comments for Hive-related profiles.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sansanichfb/incubator-hawq HAWQ-1402

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/1185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1185
    
----
commit a1334d4fb1fb0e70324ff948b58a58c165b92507
Author: Oleksandr Diachenko <od...@pivotal.io>
Date:   2017-03-22T18:36:56Z

    HAWQ-1402. Updated comments for Hive-related profiles.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1185#discussion_r107498808
  
    --- Diff: pxf/pxf-service/src/main/resources/pxf-profiles-default.xml ---
    @@ -46,6 +46,7 @@ under the License.
             <description>
                 This profile is suitable for using when connecting to Hive.
                 Supports GPDBWritable output format, as specified in FORMAT header parameter.
    +            Based on storage format, it uses one of optimized profiles(HiveRC, HiveText, HiveORC) whenever it's possible.
    --- End diff --
    
    I'd say: "It auto-detects actual file storage format and uses an optimized profile (HiveRC, HiveText, HiveORC) if applicable."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/1185


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1185#discussion_r107498956
  
    --- Diff: pxf/pxf-service/src/main/resources/pxf-profiles-default.xml ---
    @@ -46,6 +46,7 @@ under the License.
             <description>
                 This profile is suitable for using when connecting to Hive.
                 Supports GPDBWritable output format, as specified in FORMAT header parameter.
    +            Based on storage format, it uses one of optimized profiles(HiveRC, HiveText, HiveORC) whenever it's possible.
             </description>
    --- End diff --
    
    Does it also need to be changed in Ambari since there is a corresponding template there ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1185#discussion_r107746199
  
    --- Diff: pxf/pxf-service/src/main/resources/pxf-profiles-default.xml ---
    @@ -46,6 +46,7 @@ under the License.
             <description>
                 This profile is suitable for using when connecting to Hive.
                 Supports GPDBWritable output format, as specified in FORMAT header parameter.
    +            Based on storage format, it uses one of optimized profiles(HiveRC, HiveText, HiveORC) whenever it's possible.
             </description>
    --- End diff --
    
    Yes, will update it in Ambari as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---