[iceberg] branch master updated: Core: Remove redundant initialization (#6178)

[fo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 7fa9ee427a Core: Remove redundant initialization (#6178)
7fa9ee427a is described below

commit 7fa9ee427a59fdb22ad897b197a293aa13db45a8
Author: Vikash Kumar <vk...@gmail.com>
AuthorDate: Thu Nov 17 19:24:20 2022 +0530

    Core: Remove redundant initialization (#6178)
---
 core/src/main/java/org/apache/iceberg/ManifestFiles.java            | 2 +-
 core/src/main/java/org/apache/iceberg/PartitionData.java            | 2 +-
 core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java    | 6 +++---
 .../src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/core/src/main/java/org/apache/iceberg/ManifestFiles.java b/core/src/main/java/org/apache/iceberg/ManifestFiles.java
index 0155610af4..6cd9b5fa21 100644
--- a/core/src/main/java/org/apache/iceberg/ManifestFiles.java
+++ b/core/src/main/java/org/apache/iceberg/ManifestFiles.java
@@ -345,7 +345,7 @@ public class ManifestFiles {
   }
 
   private static InputFile newInputFile(FileIO io, String path, long length) {
-    boolean enabled = false;
+    boolean enabled;
 
     try {
       enabled = cachingEnabled(io);
diff --git a/core/src/main/java/org/apache/iceberg/PartitionData.java b/core/src/main/java/org/apache/iceberg/PartitionData.java
index dfe45b03ce..afee65cd9f 100644
--- a/core/src/main/java/org/apache/iceberg/PartitionData.java
+++ b/core/src/main/java/org/apache/iceberg/PartitionData.java
@@ -46,7 +46,7 @@ class PartitionData
   private final int size;
   private final Object[] data;
   private final String stringSchema;
-  private transient Schema schema = null;
+  private transient Schema schema;
 
   /** Used by Avro reflection to instantiate this class when reading manifest files. */
   PartitionData(Schema schema) {
diff --git a/core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java b/core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java
index 4ffe5432b8..47e3c2c284 100644
--- a/core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java
+++ b/core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java
@@ -34,9 +34,9 @@ import org.apache.iceberg.io.PositionOutputStream;
 import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
 
 class AvroFileAppender<D> implements FileAppender<D> {
-  private PositionOutputStream stream = null;
-  private DataFileWriter<D> writer = null;
-  private DatumWriter<?> datumWriter = null;
+  private PositionOutputStream stream;
+  private DataFileWriter<D> writer;
+  private DatumWriter<?> datumWriter;
   private org.apache.iceberg.Schema icebergSchema;
   private MetricsConfig metricsConfig;
   private long numRecords = 0L;
diff --git a/core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java b/core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java
index 805443876f..291677741e 100644
--- a/core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java
+++ b/core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java
@@ -34,7 +34,7 @@ public class UnionByNameVisitor extends SchemaWithPartnerVisitor<Integer, Boolea
 
   private final UpdateSchema api;
   private final Schema partnerSchema;
-  private boolean caseSensitive = true;
+  private boolean caseSensitive;
 
   private UnionByNameVisitor(UpdateSchema api, Schema partnerSchema, boolean caseSensitive) {
     this.api = api;