You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2016/08/27 15:13:16 UTC
[GitHub] brooklyn-server pull request #309: Do not inherit entity config defaultDispl...
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/309
Do not inherit entity config defaultDisplayName
@aledsage could you review it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-server default-displayName-inheritance
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #309
----
commit 21a6ceebe1ac4b963ae3d1da3a4534059707cc4d
Author: Valentin Aitken <bo...@gmail.com>
Date: 2016-08-27T15:11:32Z
Do not inherit entity config defaultDisplayName
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #309: Do not inherit entity config defaultDisplayName
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/309
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #309: Do not inherit entity config defaultDisplayName
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/309
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #309: Do not inherit entity config defaultDispl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #309: Do not inherit entity config defaultDisplayName
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/309
retest please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #309: Do not inherit entity config defaultDisplayName
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/309
Inherited configs are not persisted so the fix will work when applying to an Apache Brooklyn instance which already persisted such config values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #309: Do not inherit entity config defaultDisplayName
Posted by iyovcheva <gi...@git.apache.org>.
Github user iyovcheva commented on the issue:
https://github.com/apache/brooklyn-server/pull/309
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #309: Do not inherit entity config defaultDisplayName
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/309
LGTM; tests pass locally for me. Merging now.
---
Failure in jenkins looks unrelated (a timeout):
Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: Invalid object ID 11 iota=46
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on project brooklyn-launcher: There was a timeout or other error in the fork -> [Help 1]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---