[GitHub] [helix] narendly commented on a change in pull request #1500: Refine the message handler error handling logic to avoid unnecessary retry.

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #1500:
URL: https://github.com/apache/helix/pull/1500#discussion_r514901062



##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -788,8 +793,8 @@ public void onMessage(String instanceName, List<Message> messages,
     List<MessageHandler> nonStateTransitionHandlers = new ArrayList<>();
     List<NotificationContext> nonStateTransitionContexts = new ArrayList<>();
 
-    // message read
-    List<Message> readMsgs = new ArrayList<>();
+    // message to be updated in ZK
+    List<Message> updatingMsgs = new ArrayList<>();

Review comment:
       this is a little confusing. what's wrong with leaving it as `readMsgs`? `updatingMsgs` is a confusing name since messages don't update themselves. 
   
   or `msgsToBeHandled` or `msgsToHandle` could also be as equally descriptive




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org