[GitHub] [fineract] galovics commented on a diff in pull request #2402: Business date part 3

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2402:
URL: https://github.com/apache/fineract/pull/2402#discussion_r912774406


##########
fineract-provider/src/main/java/org/apache/fineract/notification/eventandlistener/SpringNotificationEventListener.java:
##########
@@ -38,6 +39,7 @@ public class SpringNotificationEventListener implements ApplicationListener<Noti
     public void onApplicationEvent(NotificationEvent event) {
         log.debug("Processing Spring notification event {}", event);
         ThreadLocalContextUtil.init(event.getContext());
+        ThreadLocalContextUtil.setActionContext(ActionContext.COB);

Review Comment:
   Do you mind explaining it why we need to have COB context here? Thanks.



##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java:
##########
@@ -168,4 +168,14 @@ public String currentSchema() {
             throw new IllegalStateException("Database type is not supported for current schema " + databaseTypeResolver.databaseType());
         }
     }
+
+    public String getBoolean(boolean condition) {
+        if (databaseTypeResolver.isMySQL()) {

Review Comment:
   Do we need this? MySQL supports `true` and `false` values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org