[GitHub] [activemq] cshannon edited a comment on pull request #647: [AMQ-7442] Support JDK11 full build and code style

[GitBox <gi...@apache.org>]

cshannon edited a comment on pull request #647:
URL: https://github.com/apache/activemq/pull/647#issuecomment-845873485


   @jbonofre - Part of the the issue (at least for me) is the URLs not working that are defined in the Javadoc plugin and that is causing errors. If I remove the following links from the javadoc plugin config in the pom file it works:
   
   `<link>http://jakarta.apache.org/commons/collections/apidocs-COLLECTIONS_3_0/</link>`
   `<link>http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/</link>`
   `<link>http://logging.apache.org/log4j/docs/api/</link>`
   
   I don't know if these have any replacements we can use or just leave them out. There might be other problems as well once fixing that.
   
   I would make sure to run through the different profiles (like the release profile) locally to test everything out to make sure it still works with JDK 8 and JDK 11. With moving to JDK 11 and also updating a bunch of maven plugins there could be other issues not easily seen as the default build may not have those features enabled (like building javadocs)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org