You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Hastyshell (via GitHub)" <gi...@apache.org> on 2026/04/10 03:17:12 UTC
[PR] [improvement](be) Enable peer replica rowset fetch by default [doris]
Hastyshell opened a new pull request, #62309:
URL: https://github.com/apache/doris/pull/62309
## Summary
- change `enable_fetch_rowsets_from_peer_replicas` to default to `true` in BE config definitions
- align the runtime default with existing pipeline test BE configs that already enable this behavior
## Testing
- Not run (config default only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "Hastyshell (via GitHub)" <gi...@apache.org>.
Hastyshell commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4241033232
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian closed pull request #62309: [chore](config) Enable fetch rowsets from peer replicas by default
URL: https://github.com/apache/doris/pull/62309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4590194237
<details>
<summary>TPC-H: <b>Total hot run time: 31723 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0c8af482ef0ec0bed09231fb64cc5c551abb77ec, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17688 4061 4112 4061
q2 q3 10823 1429 813 813
q4 4687 477 337 337
q5 7552 2253 2127 2127
q6 236 175 139 139
q7 958 778 646 646
q8 9336 1652 1553 1553
q9 5166 4912 4960 4912
q10 6386 2199 1853 1853
q11 432 272 259 259
q12 630 423 290 290
q13 18114 3333 2803 2803
q14 263 260 245 245
q15 q16 825 810 721 721
q17 916 809 970 809
q18 6961 5903 5696 5696
q19 1299 1299 1109 1109
q20 537 547 291 291
q21 6361 2876 2731 2731
q22 450 367 328 328
Total cold run time: 99620 ms
Total hot run time: 31723 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4912 4769 4897 4769
q2 q3 4978 5205 4751 4751
q4 2119 2200 1392 1392
q5 4824 4880 4685 4685
q6 231 176 129 129
q7 1852 1768 1539 1539
q8 2478 2067 2148 2067
q9 7909 7585 7396 7396
q10 4759 4684 4230 4230
q11 534 395 384 384
q12 723 739 532 532
q13 3043 3411 2745 2745
q14 277 288 260 260
q15 q16 689 690 625 625
q17 1282 1261 1251 1251
q18 7279 6924 7025 6924
q19 1116 1091 1106 1091
q20 2220 2224 1937 1937
q21 5313 4607 4481 4481
q22 520 452 400 400
Total cold run time: 57058 ms
Total hot run time: 51588 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4589714164
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/0c8af482ef0ec0bed09231fb64cc5c551abb77ec_0c8af482ef0ec0bed09231fb64cc5c551abb77ec/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/0c8af482ef0ec0bed09231fb64cc5c551abb77ec_0c8af482ef0ec0bed09231fb64cc5c551abb77ec/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 54.02% (21025/38920) |
| Line Coverage | 37.57% (199224/530340) |
| Region Coverage | 33.83% (155995/461061) |
| Branch Coverage | 34.82% (67878/194930) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4589327961
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](be) Enable peer replica rowset fetch by default [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4219914908
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4494163456
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4241564431
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/0c8af482ef0ec0bed09231fb64cc5c551abb77ec_0c8af482ef0ec0bed09231fb64cc5c551abb77ec/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/0c8af482ef0ec0bed09231fb64cc5c551abb77ec_0c8af482ef0ec0bed09231fb64cc5c551abb77ec/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.07% (20148/37965) |
| Line Coverage | 36.61% (189496/517664) |
| Region Coverage | 32.89% (147212/447646) |
| Branch Coverage | 34.00% (64403/189421) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4221039472
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62309_120edc74da3652dbfd00d733aa65d0b7095ab142_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62309_120edc74da3652dbfd00d733aa65d0b7095ab142_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.61% (27374/37186) |
| Line Coverage | 57.21% (295228/516056) |
| Region Coverage | 54.23% (245015/451781) |
| Branch Coverage | 55.97% (106361/190041) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4589328583
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4590257379
<details>
<summary>TPC-DS: <b>Total hot run time: 170514 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0c8af482ef0ec0bed09231fb64cc5c551abb77ec, data reload: false
query5 4349 669 525 525
query6 332 220 192 192
query7 4235 598 317 317
query8 350 242 212 212
query9 8772 4071 4067 4067
query10 501 346 302 302
query11 5785 2347 2137 2137
query12 185 131 128 128
query13 1345 661 458 458
query14 6145 5506 5138 5138
query14_1 4625 4523 4459 4459
query15 217 206 185 185
query16 1015 481 453 453
query17 1154 750 632 632
query18 2717 495 375 375
query19 238 207 167 167
query20 148 139 135 135
query21 219 142 152 142
query22 13617 13625 13344 13344
query23 17325 16497 16137 16137
query23_1 16324 16385 16310 16310
query24 7484 1761 1299 1299
query24_1 1305 1325 1328 1325
query25 571 469 419 419
query26 1314 322 170 170
query27 2669 554 343 343
query28 4381 2032 1985 1985
query29 973 624 497 497
query30 314 234 198 198
query31 1143 1084 957 957
query32 96 77 71 71
query33 537 357 288 288
query34 1168 1113 654 654
query35 758 795 697 697
query36 1417 1447 1214 1214
query37 158 106 86 86
query38 3215 3210 3060 3060
query39 933 933 898 898
query39_1 875 870 884 870
query40 230 140 129 129
query41 68 63 63 63
query42 111 109 107 107
query43 336 329 291 291
query44
query45 214 205 199 199
query46 1083 1170 723 723
query47 2345 2394 2288 2288
query48 378 422 308 308
query49 635 490 383 383
query50 1001 350 249 249
query51 4396 4372 4232 4232
query52 107 103 95 95
query53 255 290 208 208
query54 315 280 245 245
query55 94 88 86 86
query56 290 303 304 303
query57 1439 1413 1331 1331
query58 311 271 277 271
query59 1556 1690 1490 1490
query60 315 317 310 310
query61 158 153 157 153
query62 699 664 580 580
query63 247 208 203 203
query64 2392 776 617 617
query65
query66 1700 478 349 349
query67 29755 29673 29540 29540
query68
query69 473 358 299 299
query70 1011 984 991 984
query71 304 274 255 255
query72 3067 2684 2374 2374
query73 870 804 411 411
query74 5115 4942 4732 4732
query75 2698 2622 2282 2282
query76 2285 1146 789 789
query77 418 428 338 338
query78 12486 12563 11810 11810
query79 1385 1021 770 770
query80 653 558 443 443
query81 447 279 244 244
query82 1509 155 123 123
query83 351 287 288 287
query84 269 144 108 108
query85 908 541 454 454
query86 392 358 341 341
query87 3428 3371 3235 3235
query88 3650 2745 2747 2745
query89 441 390 344 344
query90 1960 185 202 185
query91 175 165 139 139
query92 84 74 73 73
query93 1490 1422 888 888
query94 541 366 306 306
query95 688 391 448 391
query96 1062 801 337 337
query97 2744 2734 2626 2626
query98 240 231 239 231
query99 1190 1144 1021 1021
Total cold run time: 254534 ms
Total hot run time: 170514 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "Hastyshell (via GitHub)" <gi...@apache.org>.
Hastyshell commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4222176147
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-5442861932
Closing this stale configuration-only PR. The option remains opt-in in current master, and any future default-on rollout will be evaluated separately against the current peer-read implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "Hastyshell (via GitHub)" <gi...@apache.org>.
Hastyshell commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4219944672
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4220604982
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/120edc74da3652dbfd00d733aa65d0b7095ab142_120edc74da3652dbfd00d733aa65d0b7095ab142/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/120edc74da3652dbfd00d733aa65d0b7095ab142_120edc74da3652dbfd00d733aa65d0b7095ab142/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.01% (20130/37973) |
| Line Coverage | 36.56% (189257/517675) |
| Region Coverage | 32.85% (147039/447665) |
| Branch Coverage | 33.93% (64293/189471) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4241585013
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62309_0c8af482ef0ec0bed09231fb64cc5c551abb77ec_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62309_0c8af482ef0ec0bed09231fb64cc5c551abb77ec_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.58% (27357/37179) |
| Line Coverage | 57.25% (295479/516080) |
| Region Coverage | 54.37% (245654/451778) |
| Branch Coverage | 56.08% (106558/190003) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](config) Enable fetch rowsets from peer replicas by default [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62309:
URL: https://github.com/apache/doris/pull/62309#issuecomment-4494163646
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org