You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/05 01:52:12 UTC
[GitHub] [incubator-mxnet] larroy commented on a change in pull request
#15940: Add boolean ndarray
larroy commented on a change in pull request #15940: Add boolean ndarray
URL: https://github.com/apache/incubator-mxnet/pull/15940#discussion_r331727630
##########
File path: src/operator/operator_tune.cc
##########
@@ -84,6 +85,16 @@ struct static_init_var {
__macro$(__VA_ARGS__, int32_t); \
__macro$(__VA_ARGS__, int64_t);
+#define MSHADOW_MACRO_FOREACH_TYPE_WITH_BOOL(__macro$, ...) \
+ __macro$(__VA_ARGS__, float); \
+ __macro$(__VA_ARGS__, double); \
+ __macro$(__VA_ARGS__, mshadow::half::half_t); \
+ __macro$(__VA_ARGS__, uint8_t); \
+ __macro$(__VA_ARGS__, int8_t); \
+ __macro$(__VA_ARGS__, int32_t); \
+ __macro$(__VA_ARGS__, int64_t); \
+ __macro$(__VA_ARGS__, bool)
+
#define IMPLEMENT_WORKLOAD_VALUE_FOR_TYPE(__op$, __typ$) \
Review comment:
could you please add a comment to this macro to clarify?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services