[GitHub] [maven-plugin-tools] eolivelli commented on a change in pull request #17: Do not throw exception in finally block

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #17: Do not throw exception in finally block
URL: https://github.com/apache/maven-plugin-tools/pull/17#discussion_r319727271
 
 

 ##########
 File path: maven-plugin-tools-generators/src/main/resources/help-class-source.vm
 ##########
 @@ -144,7 +144,7 @@ public class HelpMojo
                 }
                 catch ( IOException e )
                 {
-                    throw new MojoExecutionException( e.getMessage(), e );
+                    getLog().warn( "Could not close " + PLUGIN_HELP_PATH + ": " + e.getMessage() );
 
 Review comment:
   We should use a  try-with-resources block, the exception will be eventually added as 'suppressed'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services