[jira] [Commented] (CASSANDRA-19130) Implement transactional table truncation

["Alex Petrov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829887#comment-17829887 ] 

Alex Petrov commented on CASSANDRA-19130:
-----------------------------------------

Just had a very brief look at the patch. Several comments:

{code}
        if (tableMetadata.isVirtual())
            return executeLocally(state, options);
{code}

We probably should not truncate _before_ we commit, since there's nothing that guarantees we _can_ actually commit.

Also, we should not have {{cfs.truncateBlocking();}} inside the {{execute}} block of transformation, since this block has to be free of side effects. 

> Implement transactional table truncation
> ----------------------------------------
>
>                 Key: CASSANDRA-19130
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19130
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Consistency/Coordination
>            Reporter: Marcus Eriksson
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> TRUNCATE table should leverage cluster metadata to ensure consistent truncation timestamps across all replicas. The current implementation depends on all nodes being available, but this could be reimplemented as a {{Transformation}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org