You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2010/11/14 09:46:17 UTC
[jira] Created: (OWB-490) ProcessObserverMethod Type parameters are
inverted (CDITCK-174)
ProcessObserverMethod Type parameters are inverted (CDITCK-174)
---------------------------------------------------------------
Key: OWB-490
URL: https://issues.apache.org/jira/browse/OWB-490
Project: OpenWebBeans
Issue Type: Bug
Components: Events
Affects Versions: 1.1.0
Reporter: David Jencks
Assignee: Gurkan Erdogdu
Fix For: 1.1.0
cf CDITCK-174. There's some code in NotificationManager that swaps the arguments if it's an observer. I think this was because the tck was wrong. Now that its fixed this swapping causes a tck failure. The order is checked in the PortableAddObserverMethodTest and AddObserverMethodExtension which has the opposite order as the tck ProcessObserverMethodObserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-490) ProcessObserverMethod Type parameters
are inverted (CDITCK-174)
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971346#action_12971346 ]
David Jencks commented on OWB-490:
----------------------------------
There's a new 1.0.2.SP1 cdi tck available and these tests are failing for me:
testGetAnnotatedMethod(org.jboss.jsr299.tck.tests.extensions.observer.ProcessObserverMethodEventTest)
testProcessObserverMethodEventsSent(org.jboss.jsr299.tck.tests.extensions.observer.ProcessObserverMethodEventTest)
testGetObserverMethod(org.jboss.jsr299.tck.tests.extensions.observer.ProcessObserverMethodEventTest)
Have not yet investigated why.
> ProcessObserverMethod Type parameters are inverted (CDITCK-174)
> ---------------------------------------------------------------
>
> Key: OWB-490
> URL: https://issues.apache.org/jira/browse/OWB-490
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Events
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> cf CDITCK-174. There's some code in NotificationManager that swaps the arguments if it's an observer. I think this was because the tck was wrong. Now that its fixed this swapping causes a tck failure. The order is checked in the PortableAddObserverMethodTest and AddObserverMethodExtension which has the opposite order as the tck ProcessObserverMethodObserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-490) ProcessObserverMethod Type parameters
are inverted (CDITCK-174)
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971357#action_12971357 ]
David Jencks commented on OWB-490:
----------------------------------
Gurkan reverted rev 1034955 in rev 1038667 and 1038669 without including the jira number in the commit message.
> ProcessObserverMethod Type parameters are inverted (CDITCK-174)
> ---------------------------------------------------------------
>
> Key: OWB-490
> URL: https://issues.apache.org/jira/browse/OWB-490
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Events
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> cf CDITCK-174. There's some code in NotificationManager that swaps the arguments if it's an observer. I think this was because the tck was wrong. Now that its fixed this swapping causes a tck failure. The order is checked in the PortableAddObserverMethodTest and AddObserverMethodExtension which has the opposite order as the tck ProcessObserverMethodObserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-490) ProcessObserverMethod Type parameters
are inverted (CDITCK-174)
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931794#action_12931794 ]
David Jencks commented on OWB-490:
----------------------------------
Fixed to match the 1.0.2.CR3 tck in rev 1034955. Please review :-)
> ProcessObserverMethod Type parameters are inverted (CDITCK-174)
> ---------------------------------------------------------------
>
> Key: OWB-490
> URL: https://issues.apache.org/jira/browse/OWB-490
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Events
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> cf CDITCK-174. There's some code in NotificationManager that swaps the arguments if it's an observer. I think this was because the tck was wrong. Now that its fixed this swapping causes a tck failure. The order is checked in the PortableAddObserverMethodTest and AddObserverMethodExtension which has the opposite order as the tck ProcessObserverMethodObserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-490) ProcessObserverMethod Type parameters
are inverted (CDITCK-174)
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933448#action_12933448 ]
Mark Struberg commented on OWB-490:
-----------------------------------
Hi David!
Please also see Pete's comment on the TCK issue:
http://markmail.org/message/g6c4zsuuzckeai26
> ProcessObserverMethod Type parameters are inverted (CDITCK-174)
> ---------------------------------------------------------------
>
> Key: OWB-490
> URL: https://issues.apache.org/jira/browse/OWB-490
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Events
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> cf CDITCK-174. There's some code in NotificationManager that swaps the arguments if it's an observer. I think this was because the tck was wrong. Now that its fixed this swapping causes a tck failure. The order is checked in the PortableAddObserverMethodTest and AddObserverMethodExtension which has the opposite order as the tck ProcessObserverMethodObserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-490) ProcessObserverMethod Type parameters
are inverted (CDITCK-174)
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971371#action_12971371 ]
David Jencks commented on OWB-490:
----------------------------------
I reapplied rev 1034955 in rev 1049215 as the 1.0.2.SP1 tck is unchanged in these tests from 1.0.2.CR3. If you disagree please get the exclusion list or tck snapshot updated before reverting this change.
> ProcessObserverMethod Type parameters are inverted (CDITCK-174)
> ---------------------------------------------------------------
>
> Key: OWB-490
> URL: https://issues.apache.org/jira/browse/OWB-490
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Events
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> cf CDITCK-174. There's some code in NotificationManager that swaps the arguments if it's an observer. I think this was because the tck was wrong. Now that its fixed this swapping causes a tck failure. The order is checked in the PortableAddObserverMethodTest and AddObserverMethodExtension which has the opposite order as the tck ProcessObserverMethodObserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Resolved] (OWB-490) ProcessObserverMethod Type parameters
are inverted (CDITCK-174)
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg resolved OWB-490.
-------------------------------
Resolution: Fixed
should be fixed now. latest TCK is working well
> ProcessObserverMethod Type parameters are inverted (CDITCK-174)
> ---------------------------------------------------------------
>
> Key: OWB-490
> URL: https://issues.apache.org/jira/browse/OWB-490
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Events
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> cf CDITCK-174. There's some code in NotificationManager that swaps the arguments if it's an observer. I think this was because the tck was wrong. Now that its fixed this swapping causes a tck failure. The order is checked in the PortableAddObserverMethodTest and AddObserverMethodExtension which has the opposite order as the tck ProcessObserverMethodObserver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-490) ProcessObserverMethod Type parameters
are inverted (CDITCK-174)
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003399#comment-13003399 ]
Mark Struberg commented on OWB-490:
-----------------------------------
folks, this should be fixed now, isn't?
> ProcessObserverMethod Type parameters are inverted (CDITCK-174)
> ---------------------------------------------------------------
>
> Key: OWB-490
> URL: https://issues.apache.org/jira/browse/OWB-490
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Events
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> cf CDITCK-174. There's some code in NotificationManager that swaps the arguments if it's an observer. I think this was because the tck was wrong. Now that its fixed this swapping causes a tck failure. The order is checked in the PortableAddObserverMethodTest and AddObserverMethodExtension which has the opposite order as the tck ProcessObserverMethodObserver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-490) ProcessObserverMethod Type parameters
are inverted (CDITCK-174)
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971378#action_12971378 ]
Mark Struberg commented on OWB-490:
-----------------------------------
it's pretty easy: the API which got published in the JavaDoc is the one which really counts.
> ProcessObserverMethod Type parameters are inverted (CDITCK-174)
> ---------------------------------------------------------------
>
> Key: OWB-490
> URL: https://issues.apache.org/jira/browse/OWB-490
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Events
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> cf CDITCK-174. There's some code in NotificationManager that swaps the arguments if it's an observer. I think this was because the tck was wrong. Now that its fixed this swapping causes a tck failure. The order is checked in the PortableAddObserverMethodTest and AddObserverMethodExtension which has the opposite order as the tck ProcessObserverMethodObserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.