You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/23 05:44:20 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
MaxGekk opened a new pull request #28620:
URL: https://github.com/apache/spark/pull/28620
### What changes were proposed in this pull request?
Use `format()` methods for Java date-time types in `Row.jsonValue`. The PR https://github.com/apache/spark/pull/28582 added the methods to avoid conversions to days and microseconds.
### Why are the changes needed?
To avoid unnecessary overhead of converting Java date-time types to micros/days before formatting. Also formatters have to convert input micros/days back to Java types to pass instances to standard library API.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By existing tests in `RowJsonSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632998521
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632999072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632990441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632998491
**[Test build #123025 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123025/testReport)** for PR 28620 at commit [`1dac0ef`](https://github.com/apache/spark/commit/1dac0ef36744b736927e67d139f0b21477fa1a3d).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632998622
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632990317
**[Test build #123025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123025/testReport)** for PR 28620 at commit [`1dac0ef`](https://github.com/apache/spark/commit/1dac0ef36744b736927e67d139f0b21477fa1a3d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632999072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-633362609
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632989799
@cloud-fan @HyukjinKwon @hvanhovell Please, review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632990441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-633038045
**[Test build #123028 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123028/testReport)** for PR 28620 at commit [`1dac0ef`](https://github.com/apache/spark/commit/1dac0ef36744b736927e67d139f0b21477fa1a3d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632998917
**[Test build #123028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123028/testReport)** for PR 28620 at commit [`1dac0ef`](https://github.com/apache/spark/commit/1dac0ef36744b736927e67d139f0b21477fa1a3d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28620:
URL: https://github.com/apache/spark/pull/28620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-633038522
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632998522
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123025/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632998521
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-633038522
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632998917
**[Test build #123028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123028/testReport)** for PR 28620 at commit [`1dac0ef`](https://github.com/apache/spark/commit/1dac0ef36744b736927e67d139f0b21477fa1a3d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28620:
URL: https://github.com/apache/spark/pull/28620#issuecomment-632990317
**[Test build #123025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123025/testReport)** for PR 28620 at commit [`1dac0ef`](https://github.com/apache/spark/commit/1dac0ef36744b736927e67d139f0b21477fa1a3d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org