You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/07 19:53:30 UTC

Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39097/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 

Diff: https://reviews.apache.org/r/39097/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39097/#review102549
-----------------------------------------------------------


LGTM.

- Artem Harutyunyan


On Oct. 13, 2015, 11:26 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39097/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 
> 
> Diff: https://reviews.apache.org/r/39097/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39097/#review102609
-----------------------------------------------------------

Ship it!


- Joris Van Remoortere


On Oct. 13, 2015, 6:26 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39097/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 
> 
> Diff: https://reviews.apache.org/r/39097/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39097/
-----------------------------------------------------------

(Updated Oct. 13, 2015, 6:26 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 

Diff: https://reviews.apache.org/r/39097/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39097/#review102296
-----------------------------------------------------------

Ship it!


Ship It!

- Joseph Wu


On Oct. 9, 2015, 9:28 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39097/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 9:28 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 
> 
> Diff: https://reviews.apache.org/r/39097/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39097/
-----------------------------------------------------------

(Updated Oct. 10, 2015, 4:28 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 

Diff: https://reviews.apache.org/r/39097/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39097/#review101801
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake (line 39)
<https://reviews.apache.org/r/39097/#comment159292>

    Should be `endif (APPLE)`
    
    ```
    CMake Warning (dev) at 3rdparty/libprocess/3rdparty/CMakeLists.txt:295 (include):
      A logical block opening on the line
    
        /Users/josephwu/mesos/3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake:36 (if)
    
      closes on the line
    
        /Users/josephwu/mesos/3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake:39 (endif)
    
      with mis-matching arguments.
    ```


- Joseph Wu


On Oct. 7, 2015, 10:53 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39097/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 10:53 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 
> 
> Diff: https://reviews.apache.org/r/39097/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39097/#review101828
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39019, 39076, 39091, 39092, 39093, 39096, 39097]

All tests passed.

- Mesos ReviewBot


On Oct. 7, 2015, 5:53 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39097/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 5:53 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake c4d1b7b3f896f8037d922fafcdbdd0e31a70e140 
> 
> Diff: https://reviews.apache.org/r/39097/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>