[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #49: HotFix] Merged logic for upgradeModes LAST_STATE & SAVEPOINT during r…

[GitBox <gi...@apache.org>]

gyfora commented on a change in pull request #49:
URL: https://github.com/apache/flink-kubernetes-operator/pull/49#discussion_r822861245



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##########
@@ -167,15 +165,6 @@ private void upgradeFlinkJob(FlinkDeployment flinkApp, Configuration effectiveCo
         deployFlinkJob(flinkApp, effectiveConfig, savepoint);
     }
 
-    private void restoreFromLastSavepoint(FlinkDeployment flinkApp, Configuration effectiveConfig)
-            throws Exception {
-        JobStatus jobStatus = flinkApp.getStatus().getJobStatus();
-        deployFlinkJob(
-                flinkApp,
-                effectiveConfig,
-                Optional.of(jobStatus.getSavepointInfo().getLastSavepoint().getLocation()));
-    }
-

Review comment:
       Let's keep this method and simply use this :) 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org