[jira] [Commented] (IGNITE-15341) Table API. Rename confusing method getOrCreateTable.

["Valentin Kulichenko (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407694#comment-17407694 ] 

Valentin Kulichenko commented on IGNITE-15341:
----------------------------------------------

In addition, {{SchemaTable}} name is not correct - it sounds like a schema's table. It should be either {{TableSchema}}, or just {{Schema}}.

I would actually vote for the latter. I don't think that the {{Table}} prefix adds any value here.

> Table API. Rename confusing method getOrCreateTable.
> ----------------------------------------------------
>
>                 Key: IGNITE-15341
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15341
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Andrey Mashenkov
>            Priority: Major
>              Labels: UX, ignite-3
>             Fix For: 3.0.0-alpha3
>
>
> `IgniteTables.getOrCreateTable` method accepts table configuration as an argument.
> However, it is not clear if there is a guarantee the returned table will have the configuration equals to the provided one.
>  
> Let's 
> * rename the method to `createTableIfNotExists` to avoid confusion.
> * replace Consumer<TableChange> with SchemaTable.
> Note: thin client API must be fixed as well (if it is affected).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)