You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by cristofolini <gi...@git.apache.org> on 2016/03/19 22:20:12 UTC
[GitHub] cloudstack pull request: Removed unused code from CloudZoneStartup...
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/1446
Removed unused code from CloudZoneStartupProcessor
Upon analyzing the CloudZoneStartupProcessor class, we noticed most of its content consisted of either commented out or unused code. To make it easier to deal with this class in the future and to improve code readability, I've taken the liberty to remove said unused code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack lrg-cs-hackday-033
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1446.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1446
----
commit ea4b7bc52e504c99a98592de92285bdd1ee53706
Author: cristofolini <lu...@gmail.com>
Date: 2016-03-19T21:00:38Z
Removed unused code from CloudZoneStartupProcessor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9313: Remove unused code from ...
Posted by cristofolini <gi...@git.apache.org>.
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1446#issuecomment-198804084
@eriweb @GabrielBrascher Thanks for the suggestion! I've gone ahead and opened a ticket and updated the title of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from CloudZoneStartup...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1446#issuecomment-198803008
@eriweb, I didn't considered JIRA looking to this point of view (track changes in the release note). With that in mind it seems an interesting approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from CloudZoneStartup...
Posted by eriweb <gi...@git.apache.org>.
Github user eriweb commented on the pull request:
https://github.com/apache/cloudstack/pull/1446#issuecomment-198795359
Jira is used for more than you might think.
It is used to build release notes as well as a metric in board reports for community activity.
There is no reason not to file a ticket, just mark it as improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from CloudZoneStartup...
Posted by eriweb <gi...@git.apache.org>.
Github user eriweb commented on the pull request:
https://github.com/apache/cloudstack/pull/1446#issuecomment-198789993
For tracking purposes, would you mind creating a Jira ticket for this, and add the jira ID to the title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed unused code from CloudZoneStartup...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1446#issuecomment-198794064
@eriweb, as far as I know, JIRA is used for bug/issue tracking. JIRA is a way that users have to report bugs. Based on JIRA, developers can track and fix issues. I do not see why create a JIRA ticket here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---