[GitHub] [pulsar] eolivelli commented on a change in pull request #10535: Allow to overwrite the offload drive config by metadata

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #10535:
URL: https://github.com/apache/pulsar/pull/10535#discussion_r629876241



##########
File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOffloader.java
##########
@@ -485,8 +485,9 @@ private PositionImpl lastOffered() {
      * @param offloadDriverMetadata
      * @return
      */
-    private BlobStoreLocation getBlobStoreLocation(Map<String, String> offloadDriverMetadata) {
-        return (!offloadDriverMetadata.isEmpty()) ? new BlobStoreLocation(offloadDriverMetadata) :
+    BlobStoreLocation getBlobStoreLocation(Map<String, String> offloadDriverMetadata) {
+        return (offloadDriverMetadata.keySet().containsAll(getOffloadDriverMetadata().keySet())) ?

Review comment:
       I cannot understand this comparison.
   shouldn't it be `offloadDriverMetadata.equals(getOffloadDriverMetadata())` ?
   otherwise we are only checking that there is no "new" entry 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org