You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/07 18:18:06 UTC
[GitHub] [airflow] subkanthi opened a new pull request #20754: Fix numeric param deserialization
subkanthi opened a new pull request #20754:
URL: https://github.com/apache/airflow/pull/20754
related: #20442
The cleaner way would be to serialize it properly.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi closed pull request #20754: Fix numeric param deserialization
Posted by GitBox <gi...@apache.org>.
subkanthi closed pull request #20754:
URL: https://github.com/apache/airflow/pull/20754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on pull request #20754: Fix numeric param deserialization
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on pull request #20754:
URL: https://github.com/apache/airflow/pull/20754#issuecomment-1007879544
I feel this should be also done for serialisation ~~instead~~ (edit: I meant to write “as well”). If a value is ArgNotSet, it should not be serialised in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20754: Fix numeric param deserialization
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20754:
URL: https://github.com/apache/airflow/pull/20754#issuecomment-1007879544
I feel this should be also done for serialisation instead. If a value is ArgNotSet, it should not be serialised in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on pull request #20754: Fix numeric param deserialization
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on pull request #20754:
URL: https://github.com/apache/airflow/pull/20754#issuecomment-1007879544
I feel this should be also done for serialisation ~~instead~~ (edit: I meant to write “as well”). If a value is ArgNotSet, it should not be serialised in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi closed pull request #20754: Fix numeric param deserialization
Posted by GitBox <gi...@apache.org>.
subkanthi closed pull request #20754:
URL: https://github.com/apache/airflow/pull/20754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20754: Fix numeric param deserialization
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20754:
URL: https://github.com/apache/airflow/pull/20754#issuecomment-1007879544
I feel this should be also done for serialisation instead. If a value is ArgNotSet, it should not be serialised in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org