You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "meethngala (via GitHub)" <gi...@apache.org> on 2023/02/16 06:02:48 UTC
[GitHub] [gobblin] meethngala opened a new pull request, #3646: [GOBBLIN-1789] Create Generic Iceberg Data Node to Support Different Types of Catalogs
meethngala opened a new pull request, #3646:
URL: https://github.com/apache/gobblin/pull/3646
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
- https://issues.apache.org/jira/browse/GOBBLIN-1789
### Description
As part of supporting multiple Iceberg Catalogs, I am defining generic `IcebergDataNode` that will represent an Iceberg node in the Flow Graph for any type of Iceberg Catalog and not just Hive. Below are the changes added as part of this PR:
- [ ] Here are some details about my PR, including screenshots (if applicable):
- [ ] Added `IcebergDataNode` which takes a catalog Uri
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
- [ ] Added unit tests
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3646: [GOBBLIN-1789] Create Generic Iceberg Data Node to Support Different Types of Catalogs
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3646:
URL: https://github.com/apache/gobblin/pull/3646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3646: [GOBBLIN-1789] Create Generic Iceberg Data Node to Support Different Types of Catalogs
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3646:
URL: https://github.com/apache/gobblin/pull/3646#issuecomment-1432587142
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3646](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9c6060) into [master](https://codecov.io/gh/apache/gobblin/commit/26fd2445850c91a04dc1016b0ffc3e7f7a3fc915?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26fd244) will **decrease** coverage by `2.82%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3646 +/- ##
============================================
- Coverage 46.61% 43.80% -2.82%
+ Complexity 10712 2065 -8647
============================================
Files 2133 409 -1724
Lines 83637 17641 -65996
Branches 9300 2152 -7148
============================================
- Hits 38986 7727 -31259
+ Misses 41095 9057 -32038
+ Partials 3556 857 -2699
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/gobblin/fsm/FiniteStateMachine.java](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZzbS9GaW5pdGVTdGF0ZU1hY2hpbmUuamF2YQ==) | `73.48% <0.00%> (-3.04%)` | :arrow_down: |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `64.51% <0.00%> (-2.16%)` | :arrow_down: |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.29% <0.00%> (-0.66%)` | :arrow_down: |
| [...version/hive/provider/HdfsBasedUpdateProvider.java](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9wcm92aWRlci9IZGZzQmFzZWRVcGRhdGVQcm92aWRlci5qYXZh) | | |
| [.../java/org/apache/gobblin/runtime/api/FlowSpec.java](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0Zsb3dTcGVjLmphdmE=) | | |
| [.../predicates/RootDirectoryModtimeSkipPredicate.java](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHJlZGljYXRlcy9Sb290RGlyZWN0b3J5TW9kdGltZVNraXBQcmVkaWNhdGUuamF2YQ==) | | |
| [...e/job\_catalog/FSPathAlterationListenerAdaptor.java](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2NhdGFsb2cvRlNQYXRoQWx0ZXJhdGlvbkxpc3RlbmVyQWRhcHRvci5qYXZh) | | |
| [...he/gobblin/policies/count/RowCountRangePolicy.java](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3BvbGljaWVzL2NvdW50L1Jvd0NvdW50UmFuZ2VQb2xpY3kuamF2YQ==) | | |
| [...actor/extract/kafka/SimpleKafkaSchemaRegistry.java](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9TaW1wbGVLYWZrYVNjaGVtYVJlZ2lzdHJ5LmphdmE=) | | |
| [...n/service/modules/dataset/FSDatasetDescriptor.java](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L0ZTRGF0YXNldERlc2NyaXB0b3IuamF2YQ==) | | |
| ... and [1719 more](https://codecov.io/gh/apache/gobblin/pull/3646?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org