You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/07 07:54:15 UTC

[GitHub] [flink] zjuwangg opened a new pull request #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake

zjuwangg opened a new pull request #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake
URL: https://github.com/apache/flink/pull/10786
 
 
   ## What is the purpose of the change
   
   *Correct catalog doc example mistake*
   
   
   ## Brief change log
     - 84b3810 Correct catalog doc example mistake
   
   
   ## Verifying this change
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable )
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake
URL: https://github.com/apache/flink/pull/10786#issuecomment-571477396
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 84b381042c60d420b660c21b3e61d4a9c0534574 (Tue Jan 07 07:56:17 UTC 2020)
   
   **Warnings:**
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15398).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake
URL: https://github.com/apache/flink/pull/10786#issuecomment-571482453
 
 
   <!--
   Meta data
   Hash:84b381042c60d420b660c21b3e61d4a9c0534574 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4154 TriggerType:PUSH TriggerID:84b381042c60d420b660c21b3e61d4a9c0534574
   Hash:84b381042c60d420b660c21b3e61d4a9c0534574 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143356068 TriggerType:PUSH TriggerID:84b381042c60d420b660c21b3e61d4a9c0534574
   -->
   ## CI report:
   
   * 84b381042c60d420b660c21b3e61d4a9c0534574 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143356068) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4154) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zjuwangg commented on issue #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake

Posted by GitBox <gi...@apache.org>.
zjuwangg commented on issue #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake
URL: https://github.com/apache/flink/pull/10786#issuecomment-571476980
 
 
   @bowenli86 @wuchong to have a review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake
URL: https://github.com/apache/flink/pull/10786#issuecomment-571482453
 
 
   <!--
   Meta data
   Hash:84b381042c60d420b660c21b3e61d4a9c0534574 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:84b381042c60d420b660c21b3e61d4a9c0534574
   -->
   ## CI report:
   
   * 84b381042c60d420b660c21b3e61d4a9c0534574 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong merged pull request #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake
URL: https://github.com/apache/flink/pull/10786
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10786: [FLINK-15398][hotfix][doc]Correct catalog doc example mistake
URL: https://github.com/apache/flink/pull/10786#issuecomment-571482453
 
 
   <!--
   Meta data
   Hash:84b381042c60d420b660c21b3e61d4a9c0534574 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4154 TriggerType:PUSH TriggerID:84b381042c60d420b660c21b3e61d4a9c0534574
   Hash:84b381042c60d420b660c21b3e61d4a9c0534574 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143356068 TriggerType:PUSH TriggerID:84b381042c60d420b660c21b3e61d4a9c0534574
   -->
   ## CI report:
   
   * 84b381042c60d420b660c21b3e61d4a9c0534574 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143356068) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4154) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services