[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #48: [FLINK-26679] Add FileStore Continuous Reading ITCase

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #48:
URL: https://github.com/apache/flink-table-store/pull/48#discussion_r828923750



##########
File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreFactory.java
##########
@@ -197,12 +199,42 @@ public DynamicTableSink createDynamicTableSink(Context context) {
 
     // ~ Tools ------------------------------------------------------------------
 
-    private static LogStoreTableFactory createLogStoreTableFactory(Context context) {
-        return discoverLogStoreFactory(
-                context.getClassLoader(),
-                context.getCatalogTable()
-                        .getOptions()
-                        .getOrDefault(LOG_SYSTEM.key(), LOG_SYSTEM.defaultValue()));
+    private static Optional<LogStoreTableFactory> createOptionalLogStoreFactory(Context context) {
+        Configuration options = new Configuration();
+        context.getCatalogTable().getOptions().forEach(options::setString);
+
+        if (!options.get(CHANGE_TRACKING)) {
+            return Optional.empty();
+        }
+
+        if (options.get(LOG_SYSTEM) == null) {
+            // Use file store continuous reading

Review comment:
       Yes, but this is in the `createLogFactory` context, here it is implied that you want to create a reader for streaming, OK, I told you there is no LogSystem, you can only use file store continuous reading




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org