You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/01/22 04:16:22 UTC

[GitHub] JaroslavTulach commented on a change in pull request #1069: NETBEANS-1744: Support Run/Debug Focused Test Method for @Nested JUni…

JaroslavTulach commented on a change in pull request #1069: NETBEANS-1744: Support Run/Debug Focused Test Method for @Nested JUni…
URL: https://github.com/apache/incubator-netbeans/pull/1069#discussion_r249636609
 
 

 ##########
 File path: ide/projectapi/src/org/netbeans/spi/project/SingleMethod.java
 ##########
 @@ -43,14 +46,28 @@
      * @since 1.19
      */
     public SingleMethod(FileObject file, String methodName) {
-        super();
+        this(file, null, methodName);
+    }
+    
+    /**
+     * Creates a new instance holding the specified identification
+     * of a method/function in a file.
+     *
+     * @param file file to be kept in the object
+     * @param binaryClassName The binary class name of the class containing the method (as returned by {@link Class#getName()})
+     * @param methodName name of a method inside the file
+     * @exception  java.lang.IllegalArgumentException
+     *             if the file or method name is {@code null}
+     */
+    public SingleMethod(FileObject file, String binaryClassName, String methodName) {
 
 Review comment:
   Changes in API should be reflected in `apichanges.xml`, version of the module should be incremented in `manifest.mf` or project properties. New elements should have `@since` tag. Plus: all modules that depend on the new elements should depend on the new version of the API module.
   
   This is a request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists