You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/12/12 00:24:12 UTC

Review Request 64517: Added pause/resume methods to `OfferOperationStatusUpdateManager`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64517/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Repository: mesos


Description
-------

Added pause/resume methods to `OfferOperationStatusUpdateManager`.


Diffs
-----

  src/status_update_manager/offer_operation.hpp 8751f0b7b6471cab2db55bf52f45c2798e3ef192 
  src/status_update_manager/offer_operation.cpp f66690eadc0d7b16cc7de1b518904db2cab7ef82 


Diff: https://reviews.apache.org/r/64517/diff/1/


Testing
-------


Thanks,

Gaston Kleiman

Re: Review Request 64517: Added pause/resume methods to `OfferOperationStatusUpdateManager`.

Posted by Gaston Kleiman <ga...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64517/
-----------------------------------------------------------

(Updated Dec. 11, 2017, 4:57 p.m.)


Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Changes
-------

Fixed wording of comment.


Repository: mesos


Description
-------

Added pause/resume methods to `OfferOperationStatusUpdateManager`.


Diffs (updated)
-----

  src/status_update_manager/offer_operation.hpp 8751f0b7b6471cab2db55bf52f45c2798e3ef192 
  src/status_update_manager/offer_operation.cpp f66690eadc0d7b16cc7de1b518904db2cab7ef82 


Diff: https://reviews.apache.org/r/64517/diff/2/

Changes: https://reviews.apache.org/r/64517/diff/1-2/


Testing
-------


Thanks,

Gaston Kleiman

Re: Review Request 64517: Added pause/resume methods to `OfferOperationStatusUpdateManager`.

Posted by Greg Mann <gr...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64517/#review193471
-----------------------------------------------------------


Fix it, then Ship it!





src/status_update_manager/offer_operation.hpp
Lines 117 (patched)
<https://reviews.apache.org/r/64517/#comment272029>

    "Resume forwarding status updates until `pause()` is called."


- Greg Mann


On Dec. 12, 2017, 12:24 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64517/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 12:24 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added pause/resume methods to `OfferOperationStatusUpdateManager`.
> 
> 
> Diffs
> -----
> 
>   src/status_update_manager/offer_operation.hpp 8751f0b7b6471cab2db55bf52f45c2798e3ef192 
>   src/status_update_manager/offer_operation.cpp f66690eadc0d7b16cc7de1b518904db2cab7ef82 
> 
> 
> Diff: https://reviews.apache.org/r/64517/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>