You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/10/22 13:53:34 UTC
[GitHub] [activemq-artemis] ehsavoie opened a new pull request #3313: [ARTEMIS-2954]: RA doesn't use the RA specified prefix when setting u…
ehsavoie opened a new pull request #3313:
URL: https://github.com/apache/activemq-artemis/pull/3313
…p a destination.
* Fixing the fix for double prefix issue as the destiantion name wasn't
appended when the old prefix wasn't present.
Issue: https://issues.apache.org/jira/browse/ARTEMIS-2954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3313: [ARTEMIS-2954]: RA doesn't use the RA specified prefix when setting u…
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3313:
URL: https://github.com/apache/activemq-artemis/pull/3313#discussion_r510217137
##########
File path: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java
##########
@@ -597,12 +597,12 @@ private String getTopicWithPrefix(String topic) {
if (spec.getTopicPrefix() == null) {
if (spec.isEnable1xPrefixes() == null) {
if (ra.isEnable1xPrefixes() != null && ra.isEnable1xPrefixes() && !topic.startsWith(PacketImpl.OLD_TOPIC_PREFIX.toString())) {
- return PacketImpl.OLD_TOPIC_PREFIX.toString();
+ return PacketImpl.OLD_TOPIC_PREFIX.toString() + topic;
Review comment:
ouch!!! :)
glad you picked this one up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit merged pull request #3313: [ARTEMIS-2954]: RA doesn't use the RA specified prefix when setting u…
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3313:
URL: https://github.com/apache/activemq-artemis/pull/3313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org