You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/11 19:10:56 UTC
[GitHub] [airflow] ferruzzi opened a new pull request #22189: EMR Sample DAG and Docs Update
ferruzzi opened a new pull request #22189:
URL: https://github.com/apache/airflow/pull/22189
Cleans up the existing sample DAG and docs for the EMR operators.
Part of a project to simplify and standardize AWS sample dags and docs in preparation for adding System Testing.
Related: https://github.com/apache/airflow/pull/21523
Related: https://github.com/apache/airflow/pull/21475
Related: https://github.com/apache/airflow/pull/21828
Related: https://github.com/apache/airflow/pull/21920
etc...
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #22189: EMR Sample DAG and Docs Update
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on pull request #22189:
URL: https://github.com/apache/airflow/pull/22189#issuecomment-1065559318
@eladkal has looked at most/all of the previous related ones. Tagging in case he wants to keep up with it or pass. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #22189: EMR Sample DAG and Docs Update
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #22189:
URL: https://github.com/apache/airflow/pull/22189#discussion_r825002217
##########
File path: airflow/providers/amazon/aws/example_dags/example_emr_job_flow_manual_steps.py
##########
@@ -50,54 +49,58 @@
'InstanceGroups': [
{
'Name': 'Primary node',
- 'Market': 'SPOT',
+ 'Market': 'ON_DEMAND',
'InstanceRole': 'MASTER',
- 'InstanceType': 'm1.medium',
+ 'InstanceType': 'm5.xlarge',
Review comment:
These are the new default/recommended settings. The m1 series instance types are "previous generation" and no longer recommend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #22189: EMR Sample DAG and Docs Update
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #22189:
URL: https://github.com/apache/airflow/pull/22189#discussion_r825002217
##########
File path: airflow/providers/amazon/aws/example_dags/example_emr_job_flow_manual_steps.py
##########
@@ -50,54 +49,58 @@
'InstanceGroups': [
{
'Name': 'Primary node',
- 'Market': 'SPOT',
+ 'Market': 'ON_DEMAND',
'InstanceRole': 'MASTER',
- 'InstanceType': 'm1.medium',
+ 'InstanceType': 'm5.xlarge',
Review comment:
Just a note since I'm sure someone will ask; Here and below, these are the new default/recommended settings. The m1 series instance types are "previous generation" and no longer recommend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #22189: EMR Sample DAG and Docs Update
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #22189:
URL: https://github.com/apache/airflow/pull/22189#discussion_r825002609
##########
File path: airflow/providers/amazon/aws/example_dags/example_emr_job_flow_automatic_steps.py
##########
@@ -44,38 +45,40 @@
'InstanceGroups': [
{
'Name': 'Primary node',
- 'Market': 'SPOT',
+ 'Market': 'ON_DEMAND',
'InstanceRole': 'MASTER',
- 'InstanceType': 'm1.medium',
+ 'InstanceType': 'm5.xlarge',
Review comment:
Just a note since I'm sure someone will ask; These are the new default/recommended settings. The m1 series instance types are "previous generation" and no longer recommend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #22189: EMR Sample DAG and Docs Update
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #22189:
URL: https://github.com/apache/airflow/pull/22189#discussion_r825002609
##########
File path: airflow/providers/amazon/aws/example_dags/example_emr_job_flow_automatic_steps.py
##########
@@ -44,38 +45,40 @@
'InstanceGroups': [
{
'Name': 'Primary node',
- 'Market': 'SPOT',
+ 'Market': 'ON_DEMAND',
'InstanceRole': 'MASTER',
- 'InstanceType': 'm1.medium',
+ 'InstanceType': 'm5.xlarge',
Review comment:
These are the new default/recommended settings. The m1 series instance types are "previous generation" and no longer recommend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22189: EMR Sample DAG and Docs Update
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22189:
URL: https://github.com/apache/airflow/pull/22189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #22189: EMR Sample DAG and Docs Update
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #22189:
URL: https://github.com/apache/airflow/pull/22189#discussion_r825002217
##########
File path: airflow/providers/amazon/aws/example_dags/example_emr_job_flow_manual_steps.py
##########
@@ -50,54 +49,58 @@
'InstanceGroups': [
{
'Name': 'Primary node',
- 'Market': 'SPOT',
+ 'Market': 'ON_DEMAND',
'InstanceRole': 'MASTER',
- 'InstanceType': 'm1.medium',
+ 'InstanceType': 'm5.xlarge',
Review comment:
Just a note since I'm sure someone will ask; These are the new default/recommended settings. The m1 series instance types are "previous generation" and no longer recommend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22189: EMR Sample DAG and Docs Update
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22189:
URL: https://github.com/apache/airflow/pull/22189#issuecomment-1067272512
Another one for next provider's release :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #22189: EMR Sample DAG and Docs Update
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #22189:
URL: https://github.com/apache/airflow/pull/22189#discussion_r825002609
##########
File path: airflow/providers/amazon/aws/example_dags/example_emr_job_flow_automatic_steps.py
##########
@@ -44,38 +45,40 @@
'InstanceGroups': [
{
'Name': 'Primary node',
- 'Market': 'SPOT',
+ 'Market': 'ON_DEMAND',
'InstanceRole': 'MASTER',
- 'InstanceType': 'm1.medium',
+ 'InstanceType': 'm5.xlarge',
Review comment:
Just a note since I'm sure someone will ask; These are the new default/recommended settings. The m1 series instance types are "previous generation" and no longer recommend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22189: EMR Sample DAG and Docs Update
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22189:
URL: https://github.com/apache/airflow/pull/22189#issuecomment-1067271714
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org