You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/14 09:47:19 UTC

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #802: allow adding docker Private registry details while deploying cluster

davidjumani commented on a change in pull request #802:
URL: https://github.com/apache/cloudstack-primate/pull/802#discussion_r504546201



##########
File path: src/store/modules/user.js
##########
@@ -274,6 +274,16 @@ const user = {
           reject(error)
         })
       })
+    },
+    RefreshFeatures ({ commit }) {
+      return new Promise((resolve, reject) => {
+        api('listCapabilities').then(response => {
+          const result = response.listcapabilitiesresponse.capability
+          commit('SET_FEATURES', result)
+        }).catch(error => {

Review comment:
       @Pearl1594 Would not resolving the promise cause any issues ? (Promise state, GC, etc)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org