[GitHub] [hadoop] jojochuang commented on a change in pull request #2515: HDFS-15706. HttpFS: Log more information on request failures.

[GitBox <gi...@apache.org>]

jojochuang commented on a change in pull request #2515:
URL: https://github.com/apache/hadoop/pull/2515#discussion_r535514879



##########
File path: hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSExceptionProvider.java
##########
@@ -95,4 +99,9 @@ protected void log(Response.Status status, Throwable throwable) {
     LOG.warn("[{}:{}] response [{}] {}", method, path, status, message, throwable);
   }
 
+  private void logErrorFully(Response.Status status, Throwable throwable) {
+    if (LOG.isDebugEnabled()) {
+      LOG.debug("Failed with " + status, throwable);

Review comment:
       Let's use parameterized logging, shall we?
   That way, you don't need to check if debug log is enabled.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org