You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "fukua95 (via GitHub)" <gi...@apache.org> on 2024/12/06 04:56:05 UTC
[PR] feat(config): add the `partition_filters` option to disable the partitioned filters [kvrocks]
fukua95 opened a new pull request, #2688:
URL: https://github.com/apache/kvrocks/pull/2688
references: #2676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(config): add the `partition_filters` option to disable the partitioned filters [kvrocks]
Posted by "fukua95 (via GitHub)" <gi...@apache.org>.
fukua95 commented on code in PR #2688:
URL: https://github.com/apache/kvrocks/pull/2688#discussion_r1872622731
##########
src/config/config.cc:
##########
@@ -131,8 +131,8 @@ Status SetRocksdbCompression(Server *srv, const rocksdb::CompressionType compres
for (size_t i = compression_start_level; i < KVROCKS_MAX_LSM_LEVEL; i++) {
compression_per_level_builder.emplace_back(compression_option);
}
- const std::string compression_per_level = util::StringJoin(
- compression_per_level_builder, [](const auto &s) -> decltype(auto) { return s; }, ":");
+ const std::string compression_per_level =
+ util::StringJoin(compression_per_level_builder, [](const auto &s) -> decltype(auto) { return s; }, ":");
Review Comment:
Thanks, I'm doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(config): add the `partition_filters` option to disable the partitioned filters [kvrocks]
Posted by "fukua95 (via GitHub)" <gi...@apache.org>.
fukua95 commented on PR #2688:
URL: https://github.com/apache/kvrocks/pull/2688#issuecomment-2522272122
> Please avoid introducing unrelated changes.
>
> Also please ensure the version of clang-format you are using is 14. You can download it from [here](https://github.com/llvm/llvm-project/releases/tag/llvmorg-14.0.0).
thanks, I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(config): add the `partition_filters` option to disable the partitioned filters [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2688:
URL: https://github.com/apache/kvrocks/pull/2688#issuecomment-2522553565
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2688) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2688&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2688&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=2688&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [66.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=2688&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=2688&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2688)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(config): add the `partition_filters` option to disable the partitioned filters [kvrocks]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU merged PR #2688:
URL: https://github.com/apache/kvrocks/pull/2688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(config): add the `partition_filters` option to disable the partitioned filters [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #2688:
URL: https://github.com/apache/kvrocks/pull/2688#discussion_r1872621095
##########
src/config/config.cc:
##########
@@ -131,8 +131,8 @@ Status SetRocksdbCompression(Server *srv, const rocksdb::CompressionType compres
for (size_t i = compression_start_level; i < KVROCKS_MAX_LSM_LEVEL; i++) {
compression_per_level_builder.emplace_back(compression_option);
}
- const std::string compression_per_level = util::StringJoin(
- compression_per_level_builder, [](const auto &s) -> decltype(auto) { return s; }, ":");
+ const std::string compression_per_level =
+ util::StringJoin(compression_per_level_builder, [](const auto &s) -> decltype(auto) { return s; }, ":");
Review Comment:
Seems we need to revert this change to make CI pass.
Note that in the CI the clang-format version is 14. Different versions may lead to different format results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org