[GitHub] brodybits commented on issue #569: SDK versions are resolved after plugins gradle extensions

[GitBox <gi...@apache.org>]

brodybits commented on issue #569: SDK versions are resolved after plugins gradle extensions
URL: https://github.com/apache/cordova-android/issues/569#issuecomment-444535883
 
 
   I just labeled this as a bug, maybe similar to #599.
   
   As I said in <https://github.com/apache/cordova-android/pull/568#issuecomment-444179258> the standard way for a plugin to specify minimum SDK version is in `sdk-element` (<https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#edit-config>), but it seems to be ignored if the value is also specified in Gradle (<https://github.com/apache/cordova-android/issues/599#issuecomment-444283762>).
   
   As discussed in #599 there is an issue if both a plugin and user config specify SDK version. The suggestion in #599 to move the `PLUGIN GRADLE EXTENSIONS` comments is good but could prove to be a breaking change in some cases.
   
   I think the best solution would be to move the plugin gradle extensions into a separate Gradle file. I think this should be done in a major release, with plenty of advance warning with documentation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org