You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2025/04/30 06:47:53 UTC
[PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
xuzifu666 opened a new pull request, #4351:
URL: https://github.com/apache/calcite/pull/4351
As description in JIRA: https://issues.apache.org/jira/browse/CALCITE-6995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2841272737
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351) **Quality Gate passed**
Issues
 [4 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [80.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] Support FULL JOIN in StarRocks/Doris Dialect [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2844682179
> I hope we can change this pr summary to `Support FULL JOIN in StarRocks/Doris Dialect`
Make sense, I had changed the title to Support FULL JOIN in StarRocks/Doris Dialect, thanks~ @NobiGo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2067977141
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -1335,7 +1335,9 @@ private LockWrapper exclusiveCleanDb(Connection c) throws SQLException {
/**
* Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-4619">[CALCITE-4619]
- * "Full join" generates an incorrect execution plan under mysql</a>. */
Review Comment:
Thanks for the suggestion and agree with it,had add a new test case for the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "asolimando (via GitHub)" <gi...@apache.org>.
asolimando commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2068170003
##########
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java:
##########
@@ -214,6 +214,10 @@ public final class CalciteSystemProperty<T> {
return ".";
});
+
Review Comment:
Let's have them as `private static final` in `JdbcAdapterTest` for now, we can move them in a "common" location and adjust visibility if they are going to be used elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "asolimando (via GitHub)" <gi...@apache.org>.
asolimando commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2841079828
> > @xuzifu666 can you check sonar report and fix what makes sense? Thanks!
>
> In my view,sonar test is success,and other test is ok,which sonar error do you mean?(can show the link to me)@asolimando
It's [this link](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) that gets published as a recap in messages like [this one](https://github.com/apache/calcite/pull/4351#issuecomment-2841049798).
In this case there are 6 new issues, some are clearly addressable and correct (dangling imports), some others could be addressed (repetition of string). There might also be false positives sometimes, or debatable issues like "brain methods" etc. which are very much present in the codebase and mostly accepted.
In general it's worth checking with grain of salt, not every issue reported has to be addressed, but for trivial things like imports it spares time for everyone and makes the review total time shorter.
When you see "success" it means the analysis succeeded, not that there aren't problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2068357675
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -1355,6 +1355,27 @@ private LockWrapper exclusiveCleanDb(Connection c) throws SQLException {
.runs();
}
+ /**
+ * Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6995">[CALCITE-6995]
+ * StarRocks/Doris should support full join</a>.*/
+ @Test void testFullJoinSupportedDialect() {
+ CalciteAssert.model(JdbcTest.SCOTT_MODEL)
+ .enable(CalciteAssert.DB != CalciteAssert.DatabaseInstance.H2
Review Comment:
I think here should test for all DBs except the two excluded, because other db can support full join. @asolimando
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "asolimando (via GitHub)" <gi...@apache.org>.
asolimando commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2067967167
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -1335,7 +1335,9 @@ private LockWrapper exclusiveCleanDb(Connection c) throws SQLException {
/**
* Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-4619">[CALCITE-4619]
- * "Full join" generates an incorrect execution plan under mysql</a>. */
Review Comment:
I feel a separate test case would be cleaner, `testFullJoinSupportedDialect` or similar for those who support it, the existing (untouched?) for those who don't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "asolimando (via GitHub)" <gi...@apache.org>.
asolimando commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2068170003
##########
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java:
##########
@@ -214,6 +214,10 @@ public final class CalciteSystemProperty<T> {
return ".";
});
+
Review Comment:
Let's have them as `private static final` (capital casing) in `JdbcAdapterTest` for now, we can move them in a "common" location and adjust visibility if they are going to be used elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "asolimando (via GitHub)" <gi...@apache.org>.
asolimando commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2841054224
@xuzifu666 can you check sonar report and fix what makes sense? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "NobiGo (via GitHub)" <gi...@apache.org>.
NobiGo commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2841251139
> @xuzifu666 can you check sonar report and fix what makes sense? Thanks!
I haven't paid attention to this test before. It often runs rather slowly. I will pay more attention to it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2841032174
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [66.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2841049798
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351) **Quality Gate passed**
Issues
 [6 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [66.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] Support FULL JOIN in StarRocks/Doris Dialect [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2070173856
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -1355,6 +1355,27 @@ private LockWrapper exclusiveCleanDb(Connection c) throws SQLException {
.runs();
}
+ /**
+ * Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6995">[CALCITE-6995]
+ * StarRocks/Doris should support full join</a>.*/
Review Comment:
Thanks for remidner, had fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] Support FULL JOIN in StarRocks/Doris Dialect [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2844703214
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [90.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] Support FULL JOIN in StarRocks/Doris Dialect [calcite]
Posted by "NobiGo (via GitHub)" <gi...@apache.org>.
NobiGo merged PR #4351:
URL: https://github.com/apache/calcite/pull/4351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2841067687
> @xuzifu666 can you check sonar report and fix what makes sense? Thanks!
In my view,sonar test is success,and other test is ok,which sonar error do you mean?(can show the link to me)@asolimando
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "NobiGo (via GitHub)" <gi...@apache.org>.
NobiGo commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2070158306
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -1355,6 +1355,27 @@ private LockWrapper exclusiveCleanDb(Connection c) throws SQLException {
.runs();
}
+ /**
+ * Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6995">[CALCITE-6995]
+ * StarRocks/Doris should support full join</a>.*/
Review Comment:
We should be consistent with the others. `</a>. */`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2841316100
> ## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351) **Quality Gate passed**
> Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=ACCEPTED)
>
> Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [90.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_duplicated_lines_density&view=list)
>
> [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351)
According sonar report warning had been fixed. @asolimando
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2841311500
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [90.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] Support FULL JOIN in StarRocks/Doris Dialect [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2844704780
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [90.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4351&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4351)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 closed pull request #4351: [CALCITE-6995] StarRocks/Doris should support full join
URL: https://github.com/apache/calcite/pull/4351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2068186194
##########
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java:
##########
@@ -214,6 +214,10 @@ public final class CalciteSystemProperty<T> {
return ".";
});
+
Review Comment:
Maybe we cannot put them in JdbcAdapterTest because need these static String in CalciteAssert (in Calcite testkit and JdbcAdapterTest is in core moudle ), how about put them in CalciteAssert with private static final ? @asolimando
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "asolimando (via GitHub)" <gi...@apache.org>.
asolimando commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2068325183
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -1355,6 +1355,27 @@ private LockWrapper exclusiveCleanDb(Connection c) throws SQLException {
.runs();
}
+ /**
+ * Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6995">[CALCITE-6995]
+ * StarRocks/Doris should support full join</a>.*/
+ @Test void testFullJoinSupportedDialect() {
+ CalciteAssert.model(JdbcTest.SCOTT_MODEL)
+ .enable(CalciteAssert.DB != CalciteAssert.DatabaseInstance.H2
Review Comment:
Q: I see no other tests where we enable when the DB is not set to a given set of values (inequality), we always enable on specific values (equality). In this case, do we want to enable it specifically for Doris/StarRocks or for all DBs except the two you have excluded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6995] StarRocks/Doris should support full join [calcite]
Posted by "NobiGo (via GitHub)" <gi...@apache.org>.
NobiGo commented on PR #4351:
URL: https://github.com/apache/calcite/pull/4351#issuecomment-2844656872
I hope we can change this pr summary to `Support FULL JOIN in StarRocks/Doris Dialect`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org