You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sk0x50 (via GitHub)" <gi...@apache.org> on 2025/04/17 14:08:05 UTC
[PR] IGNITE-25179 Fix AssertionError on table stopping when the colocation is enabled [ignite-3]
sk0x50 opened a new pull request, #5664:
URL: https://github.com/apache/ignite-3/pull/5664
https://issues.apache.org/jira/browse/IGNITE-4240
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25179 Fix AssertionError on table stopping when the colocation is enabled [ignite-3]
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #5664:
URL: https://github.com/apache/ignite-3/pull/5664#discussion_r2054205812
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ZoneResourcesManager.java:
##########
@@ -182,6 +182,10 @@ void destroyZonePartitionResources(ZonePartitionId zonePartitionId) {
CompletableFuture<Void> removeTableResources(ZonePartitionId zonePartitionId, int tableId) {
ZonePartitionResources resources = getZonePartitionResources(zonePartitionId);
+ if (resources == null) {
+ return CompletableFuture.completedFuture(null);
Review Comment:
```suggestion
return nullCompletedFuture();
```
##########
modules/low-watermark/src/main/java/org/apache/ignite/internal/lowwatermark/LowWatermarkImpl.java:
##########
@@ -234,18 +234,12 @@ HybridTimestamp createNewLowWatermarkCandidate() {
}
private void setLowWatermark(HybridTimestamp newLowWatermark) {
- updateLowWatermarkLock.writeLock().lock();
Review Comment:
Why is protection with the write lock removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25179 Fix AssertionError on table stopping when the colocation is enabled [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 merged PR #5664:
URL: https://github.com/apache/ignite-3/pull/5664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25179 Fix AssertionError on table stopping when the colocation is enabled [ignite-3]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #5664:
URL: https://github.com/apache/ignite-3/pull/5664#discussion_r2053855692
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -1586,6 +1586,8 @@ public void loadTableListenerToZoneReplica(
) {
ZonePartitionResources resources = zoneResourcesManager.getZonePartitionResources(zonePartitionId);
+ assert resources != null : "Zone partition resources not found [zonePartitionId=" + zonePartitionId + ']';
Review Comment:
Using an assert as the sole check may not enforce the non-null invariant in production (when assertions are disabled). Consider adding an explicit runtime null check and appropriate error handling.
```suggestion
Objects.requireNonNull(resources, "Zone partition resources not found [zonePartitionId=" + zonePartitionId + ']');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25179 Fix AssertionError on table stopping when the colocation is enabled [ignite-3]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 commented on code in PR #5664:
URL: https://github.com/apache/ignite-3/pull/5664#discussion_r2055402854
##########
modules/low-watermark/src/main/java/org/apache/ignite/internal/lowwatermark/LowWatermarkImpl.java:
##########
@@ -234,18 +234,12 @@ HybridTimestamp createNewLowWatermarkCandidate() {
}
private void setLowWatermark(HybridTimestamp newLowWatermark) {
- updateLowWatermarkLock.writeLock().lock();
Review Comment:
This method is called only from one place `waitForLocksAndSetLowWatermark`, where the corresponding write lock is already acquired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org